summaryrefslogtreecommitdiff
path: root/apply.c
diff options
context:
space:
mode:
authorJunio C Hamano <gitster@pobox.com>2017-07-07 01:14:45 (GMT)
committerJunio C Hamano <gitster@pobox.com>2017-07-07 01:14:45 (GMT)
commitf9b3252b2a4b3dbaa9f8434cdd2b8fd3013519f1 (patch)
treebdd247b0ad36352a532c067b1f7196a7caee10e9 /apply.c
parentcbb8704adb8b6199a220a7b3770437b24cf1d5f8 (diff)
parent8bc172e5f29894d440aab772ae3a49eb2eaf5585 (diff)
downloadgit-f9b3252b2a4b3dbaa9f8434cdd2b8fd3013519f1.zip
git-f9b3252b2a4b3dbaa9f8434cdd2b8fd3013519f1.tar.gz
git-f9b3252b2a4b3dbaa9f8434cdd2b8fd3013519f1.tar.bz2
Merge branch 'rs/apply-avoid-over-reading'
Code clean-up to fix possible buffer over-reading. * rs/apply-avoid-over-reading: apply: use starts_with() in gitdiff_verify_name()
Diffstat (limited to 'apply.c')
-rw-r--r--apply.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/apply.c b/apply.c
index c442b89..946be4d 100644
--- a/apply.c
+++ b/apply.c
@@ -976,8 +976,7 @@ static int gitdiff_verify_name(struct apply_state *state,
}
free(another);
} else {
- /* expect "/dev/null" */
- if (memcmp("/dev/null", line, 9) || line[9] != '\n')
+ if (!starts_with(line, "/dev/null\n"))
return error(_("git apply: bad git-diff - expected /dev/null on line %d"), state->linenr);
}