summaryrefslogtreecommitdiff
path: root/README
diff options
context:
space:
mode:
authorNguyễn Thái Ngọc Duy <pclouds@gmail.com>2013-01-01 02:44:02 (GMT)
committerJunio C Hamano <gitster@pobox.com>2013-01-01 23:31:18 (GMT)
commit3a078dec3327fb68faa7c800040f89db3e38e6e5 (patch)
tree368d0819941fd8758a932776e07aaf975fc4bc6d /README
parentd5d80e12bd755197352bdb0e9b2291c896946abd (diff)
downloadgit-3a078dec3327fb68faa7c800040f89db3e38e6e5.zip
git-3a078dec3327fb68faa7c800040f89db3e38e6e5.tar.gz
git-3a078dec3327fb68faa7c800040f89db3e38e6e5.tar.bz2
wildmatch: fix "**" special case
"**" is adjusted to only be effective when surrounded by slashes, in 40bbee0 (wildmatch: adjust "**" behavior - 2012-10-15). Except that the commit did it wrong: 1. when it checks for "the preceding slash unless ** is at the beginning", it compares to wrong pointer. It should have compared to the beginning of the pattern, not the text. 2. prev_p points to the character before "**", not the first "*". The correct comparison must be "prev_p < pattern" or "prev_p + 1 == pattern", not "prev_p == pattern". 3. The pattern must be surrounded by slashes unless it's at the beginning or the end of the pattern. We do two checks: one for the preceding slash and one the trailing slash. Both checks must be met. The use of "||" is wrong. This patch fixes all above. Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'README')
0 files changed, 0 insertions, 0 deletions