diff options
| author | Anders Kaseorg <andersk@MIT.EDU> | 2010-08-27 17:38:16 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2010-08-31 16:52:48 (GMT) |
| commit | d8a94803842989582989fd5f5c3062c49134ad5b (patch) | |
| tree | 69a05d2b38d1793a33fdf51ee27943ec14570ef6 | |
| parent | eec0daf6fd5a31cda601caeaa3a0bfebf2d17fe8 (diff) | |
| download | git-d8a94803842989582989fd5f5c3062c49134ad5b.zip git-d8a94803842989582989fd5f5c3062c49134ad5b.tar.gz git-d8a94803842989582989fd5f5c3062c49134ad5b.tar.bz2 | |
gitweb: Don't die_error in git_tag after already printing headers
This fixes an XML error when visiting a nonexistent tag
(i.e. "../gitweb.cgi?p=git.git;a=tag;h=refs/tags/BADNAME").
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Acked-by: Jakub Narebski <jnareb@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rwxr-xr-x | gitweb/gitweb.perl | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index d0687f4..a85e2f6 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -5191,15 +5191,15 @@ sub git_summary { } sub git_tag { - my $head = git_get_head_hash($project); - git_header_html(); - git_print_page_nav('','', $head,undef,$head); my %tag = parse_tag($hash); if (! %tag) { die_error(404, "Unknown tag object"); } + my $head = git_get_head_hash($project); + git_header_html(); + git_print_page_nav('','', $head,undef,$head); git_print_header_div('commit', esc_html($tag{'name'}), $hash); print "<div class=\"title_text\">\n" . "<table class=\"object_header\">\n" . |