diff options
| author | Elijah Newren <newren@gmail.com> | 2020-03-11 15:30:22 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2020-03-11 19:11:05 (GMT) |
| commit | 9a1b7474d6babad5fabed9a2926a57d875f3820b (patch) | |
| tree | 865d615e5582efc65b870e07eb91f3ead0d573b2 | |
| parent | 937d1436302582c4e769594a805978d03e89ad59 (diff) | |
| download | git-9a1b7474d6babad5fabed9a2926a57d875f3820b.zip git-9a1b7474d6babad5fabed9a2926a57d875f3820b.tar.gz git-9a1b7474d6babad5fabed9a2926a57d875f3820b.tar.bz2 | |
sequencer: clear state upon dropping a become-empty commit
In commit e98c4269c8 ("rebase (interactive-backend): fix handling of
commits that become empty", 2020-02-15), the merge backend was changed
to drop commits that did not start empty but became so after being
applied (because their changes were a subset of what was already
upstream). This new code path did not need to go through the process of
creating a commit, since we were dropping the commit instead.
Unfortunately, this also means we bypassed the clearing of the
CHERRY_PICK_HEAD and MERGE_MSG files, which if there were no further
commits to cherry-pick would mean that the rebase would end but assume
there was still an operation in progress. Ensure that we clear such
state files when we decide to drop the commit.
Signed-off-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | sequencer.c | 2 | ||||
| -rwxr-xr-x | t/t3424-rebase-empty.sh | 8 |
2 files changed, 10 insertions, 0 deletions
diff --git a/sequencer.c b/sequencer.c index f8e242b..df89ff4 100644 --- a/sequencer.c +++ b/sequencer.c @@ -1955,6 +1955,8 @@ static int do_pick_commit(struct repository *r, flags |= ALLOW_EMPTY; } else if (allow == 2) { drop_commit = 1; + unlink(git_path_cherry_pick_head(r)); + unlink(git_path_merge_msg(r)); fprintf(stderr, _("dropping %s %s -- patch contents already upstream\n"), oid_to_hex(&commit->object.oid), msg.subject); diff --git a/t/t3424-rebase-empty.sh b/t/t3424-rebase-empty.sh index 98fc2a5..e1e3051 100755 --- a/t/t3424-rebase-empty.sh +++ b/t/t3424-rebase-empty.sh @@ -123,4 +123,12 @@ test_expect_success 'rebase --interactive uses default of --empty=ask' ' test_cmp expect actual ' +test_expect_success 'rebase --merge does not leave state laying around' ' + git checkout -B testing localmods~2 && + git rebase --merge upstream && + + test_path_is_missing .git/CHERRY_PICK_HEAD && + test_path_is_missing .git/MERGE_MSG +' + test_done |