diff options
| author | Michael Haggerty <mhagger@alum.mit.edu> | 2011-09-27 04:46:53 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2011-09-27 16:58:47 (GMT) |
| commit | 852844561e8daaa6689cab48a725f764ad5779cb (patch) | |
| tree | 4237e4e34687ab836086c83c7325006a4068d495 | |
| parent | 632052641517de1a965c1f045b97d2eaa541b2e9 (diff) | |
| download | git-852844561e8daaa6689cab48a725f764ad5779cb.zip git-852844561e8daaa6689cab48a725f764ad5779cb.tar.gz git-852844561e8daaa6689cab48a725f764ad5779cb.tar.bz2 | |
notes_merge_commit(): do not pass temporary buffer to other function
It is unsafe to pass a temporary buffer as an argument to
read_directory().
Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Acked-by: Johan Herland <johan@herland.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | notes-merge.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/notes-merge.c b/notes-merge.c index e1aaf43..baaf31f 100644 --- a/notes-merge.c +++ b/notes-merge.c @@ -680,7 +680,7 @@ int notes_merge_commit(struct notes_merge_options *o, * Finally store the new commit object SHA1 into 'result_sha1'. */ struct dir_struct dir; - const char *path = git_path(NOTES_MERGE_WORKTREE "/"); + char *path = xstrdup(git_path(NOTES_MERGE_WORKTREE "/")); int path_len = strlen(path), i; const char *msg = strstr(partial_commit->buffer, "\n\n"); @@ -720,6 +720,7 @@ int notes_merge_commit(struct notes_merge_options *o, result_sha1); OUTPUT(o, 4, "Finalized notes merge commit: %s", sha1_to_hex(result_sha1)); + free(path); return 0; } |