diff options
author | Jeff King <peff@peff.net> | 2022-08-19 10:08:37 (GMT) |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2022-08-19 19:18:55 (GMT) |
commit | 7718827a2d4ec90c9cbdb7ec01f68065bdb52dc2 (patch) | |
tree | 9528cbdcffdc5575a292901604102211e886db0b | |
parent | c006e9fa59c02261738e20890f1aecd78f9db707 (diff) | |
download | git-7718827a2d4ec90c9cbdb7ec01f68065bdb52dc2.zip git-7718827a2d4ec90c9cbdb7ec01f68065bdb52dc2.tar.gz git-7718827a2d4ec90c9cbdb7ec01f68065bdb52dc2.tar.bz2 |
refs: mark unused virtual method parameters
The refs code uses various polymorphic types (e.g., loose vs packed
ref_stores, abstracted iterators). Not every virtual function or
callback needs all of its parameters. Let's mark the unused ones to
quiet -Wunused-parameter.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rw-r--r-- | refs/files-backend.c | 10 | ||||
-rw-r--r-- | refs/iterator.c | 6 | ||||
-rw-r--r-- | refs/packed-backend.c | 14 |
3 files changed, 16 insertions, 14 deletions
diff --git a/refs/files-backend.c b/refs/files-backend.c index 972701c..13bfdb7 100644 --- a/refs/files-backend.c +++ b/refs/files-backend.c @@ -2202,8 +2202,8 @@ static int files_reflog_iterator_advance(struct ref_iterator *ref_iterator) return ok; } -static int files_reflog_iterator_peel(struct ref_iterator *ref_iterator, - struct object_id *peeled) +static int files_reflog_iterator_peel(struct ref_iterator *UNUSED(ref_iterator), + struct object_id *UNUSED(peeled)) { BUG("ref_iterator_peel() called for reflog_iterator"); } @@ -2257,7 +2257,7 @@ static struct ref_iterator *reflog_iterator_begin(struct ref_store *ref_store, static enum iterator_selection reflog_iterator_select( struct ref_iterator *iter_worktree, struct ref_iterator *iter_common, - void *cb_data) + void *UNUSED(cb_data)) { if (iter_worktree) { /* @@ -2985,7 +2985,7 @@ cleanup: static int files_transaction_abort(struct ref_store *ref_store, struct ref_transaction *transaction, - struct strbuf *err) + struct strbuf *UNUSED(err)) { struct files_ref_store *refs = files_downcast(ref_store, 0, "ref_transaction_abort"); @@ -3261,7 +3261,7 @@ static int files_reflog_expire(struct ref_store *ref_store, return -1; } -static int files_init_db(struct ref_store *ref_store, struct strbuf *err) +static int files_init_db(struct ref_store *ref_store, struct strbuf *UNUSED(err)) { struct files_ref_store *refs = files_downcast(ref_store, REF_STORE_WRITE, "init_db"); diff --git a/refs/iterator.c b/refs/iterator.c index b2e56ba..e34921d 100644 --- a/refs/iterator.c +++ b/refs/iterator.c @@ -51,8 +51,8 @@ static int empty_ref_iterator_advance(struct ref_iterator *ref_iterator) return ref_iterator_abort(ref_iterator); } -static int empty_ref_iterator_peel(struct ref_iterator *ref_iterator, - struct object_id *peeled) +static int empty_ref_iterator_peel(struct ref_iterator *UNUSED(ref_iterator), + struct object_id *UNUSED(peeled)) { BUG("peel called for empty iterator"); } @@ -238,7 +238,7 @@ struct ref_iterator *merge_ref_iterator_begin( */ static enum iterator_selection overlay_iterator_select( struct ref_iterator *front, struct ref_iterator *back, - void *cb_data) + void *UNUSED(cb_data)) { int cmp; diff --git a/refs/packed-backend.c b/refs/packed-backend.c index 97b6837..a45bb68 100644 --- a/refs/packed-backend.c +++ b/refs/packed-backend.c @@ -726,7 +726,7 @@ static struct snapshot *get_snapshot(struct packed_ref_store *refs) } static int packed_read_raw_ref(struct ref_store *ref_store, const char *refname, - struct object_id *oid, struct strbuf *referent, + struct object_id *oid, struct strbuf *UNUSED(referent), unsigned int *type, int *failure_errno) { struct packed_ref_store *refs = @@ -1078,7 +1078,8 @@ int packed_refs_is_locked(struct ref_store *ref_store) static const char PACKED_REFS_HEADER[] = "# pack-refs with: peeled fully-peeled sorted \n"; -static int packed_init_db(struct ref_store *ref_store, struct strbuf *err) +static int packed_init_db(struct ref_store *UNUSED(ref_store), + struct strbuf *UNUSED(err)) { /* Nothing to do. */ return 0; @@ -1473,7 +1474,7 @@ failure: static int packed_transaction_abort(struct ref_store *ref_store, struct ref_transaction *transaction, - struct strbuf *err) + struct strbuf *UNUSED(err)) { struct packed_ref_store *refs = packed_downcast( ref_store, @@ -1512,7 +1513,7 @@ cleanup: return ret; } -static int packed_initial_transaction_commit(struct ref_store *ref_store, +static int packed_initial_transaction_commit(struct ref_store *UNUSED(ref_store), struct ref_transaction *transaction, struct strbuf *err) { @@ -1568,7 +1569,8 @@ static int packed_delete_refs(struct ref_store *ref_store, const char *msg, return ret; } -static int packed_pack_refs(struct ref_store *ref_store, unsigned int flags) +static int packed_pack_refs(struct ref_store *UNUSED(ref_store), + unsigned int UNUSED(flags)) { /* * Packed refs are already packed. It might be that loose refs @@ -1578,7 +1580,7 @@ static int packed_pack_refs(struct ref_store *ref_store, unsigned int flags) return 0; } -static struct ref_iterator *packed_reflog_iterator_begin(struct ref_store *ref_store) +static struct ref_iterator *packed_reflog_iterator_begin(struct ref_store *UNUSED(ref_store)) { return empty_ref_iterator_begin(); } |