diff options
| author | Jeff King <peff@peff.net> | 2018-07-24 10:51:39 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2018-07-24 17:19:29 (GMT) |
| commit | 765b496dc6963ad8aaf40e9ac5dee358aa7fea47 (patch) | |
| tree | 0d0eb4cd2ab22e4c356c098d5fd48f5a37722999 | |
| parent | f3e76ed228d60688b49dbc2735e4633e55969e30 (diff) | |
| download | git-765b496dc6963ad8aaf40e9ac5dee358aa7fea47.zip git-765b496dc6963ad8aaf40e9ac5dee358aa7fea47.tar.gz git-765b496dc6963ad8aaf40e9ac5dee358aa7fea47.tar.bz2 | |
pass st.st_size as hint for strbuf_readlink()
When we initially added the strbuf_readlink() function in
b11b7e13f4 (Add generic 'strbuf_readlink()' helper function,
2008-12-17), the point was that we generally have a _guess_
as to the correct size based on the stat information, but we
can't necessarily trust it.
Over the years, a few callers have grown up that simply pass
in 0, even though they have the stat information. Let's have
them pass in their hint for consistency (and in theory
efficiency, since it may avoid an extra resize/syscall loop,
but neither location is probably performance critical).
Note that st.st_size is actually an off_t, so in theory we
need xsize_t() here. But none of the other callsites use it,
and since this is just a hint, it doesn't matter either way
(if we wrap we'll simply start with a too-small hint and
then eventually complain when we cannot allocate the
memory).
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | builtin/init-db.c | 3 | ||||
| -rw-r--r-- | refs/files-backend.c | 2 |
2 files changed, 3 insertions, 2 deletions
diff --git a/builtin/init-db.c b/builtin/init-db.c index 4ecf909..12ddda7 100644 --- a/builtin/init-db.c +++ b/builtin/init-db.c @@ -73,7 +73,8 @@ static void copy_templates_1(struct strbuf *path, struct strbuf *template_path, continue; else if (S_ISLNK(st_template.st_mode)) { struct strbuf lnk = STRBUF_INIT; - if (strbuf_readlink(&lnk, template_path->buf, 0) < 0) + if (strbuf_readlink(&lnk, template_path->buf, + st_template.st_size) < 0) die_errno(_("cannot readlink '%s'"), template_path->buf); if (symlink(lnk.buf, path->buf)) die_errno(_("cannot symlink '%s' '%s'"), diff --git a/refs/files-backend.c b/refs/files-backend.c index a9a066d..c110c25 100644 --- a/refs/files-backend.c +++ b/refs/files-backend.c @@ -363,7 +363,7 @@ stat_ref: /* Follow "normalized" - ie "refs/.." symlinks by hand */ if (S_ISLNK(st.st_mode)) { strbuf_reset(&sb_contents); - if (strbuf_readlink(&sb_contents, path, 0) < 0) { + if (strbuf_readlink(&sb_contents, path, st.st_size) < 0) { if (errno == ENOENT || errno == EINVAL) /* inconsistent with lstat; retry */ goto stat_ref; |