diff options
| author | Elia Pinto <gitter.spiros@gmail.com> | 2014-04-28 12:57:37 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2014-04-29 19:44:39 (GMT) |
| commit | 714c71b2b1531f7e1099d17ab8ae03fa21f4b88c (patch) | |
| tree | 96539992141507ea2a4df9b7fea93b28f66b8c77 | |
| parent | c9e454ccef2f572ce532e29b9d1317c02764545e (diff) | |
| download | git-714c71b2b1531f7e1099d17ab8ae03fa21f4b88c.zip git-714c71b2b1531f7e1099d17ab8ae03fa21f4b88c.tar.gz git-714c71b2b1531f7e1099d17ab8ae03fa21f4b88c.tar.bz2 | |
t1050-large.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command
substitution instead of using the backquotes `...`.
The backquoted form is the traditional method for command
substitution, and is supported by POSIX. However, all but the
simplest uses become complicated quickly. In particular, embedded
command substitutions and/or the use of double quotes require
careful escaping with the backslash character.
The patch was generated by:
for _f in $(find . -name "*.sh")
do
sed -i 's@`\(.*\)`@$(\1)@g' ${_f}
done
and then carefully proof-read.
Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
Reviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rwxr-xr-x | t/t1050-large.sh | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/t/t1050-large.sh b/t/t1050-large.sh index fd10528..aea4936 100755 --- a/t/t1050-large.sh +++ b/t/t1050-large.sh @@ -131,7 +131,7 @@ test_expect_success 'git-show a large file' ' ' test_expect_success 'index-pack' ' - git clone file://"`pwd`"/.git foo && + git clone file://"$(pwd)"/.git foo && GIT_DIR=non-existent git index-pack --strict --verify foo/.git/objects/pack/*.pack ' @@ -140,7 +140,7 @@ test_expect_success 'repack' ' ' test_expect_success 'pack-objects with large loose object' ' - SHA1=`git hash-object huge` && + SHA1=$(git hash-object huge) && test_create_repo loose && echo $SHA1 | git pack-objects --stdout | GIT_ALLOC_LIMIT=0 GIT_DIR=loose/.git git unpack-objects && |