summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJunio C Hamano <gitster@pobox.com>2009-08-27 05:17:25 (GMT)
committerJunio C Hamano <gitster@pobox.com>2009-08-27 05:21:30 (GMT)
commit606417bc6dba270ea2b0867cd490c2b57cb3bfa8 (patch)
treeafc71dc90caaf952cdd55d4b09a92f5b4a64a039
parent32f4cc49ae742e496355bea93c7b9481336f12cd (diff)
downloadgit-606417bc6dba270ea2b0867cd490c2b57cb3bfa8.zip
git-606417bc6dba270ea2b0867cd490c2b57cb3bfa8.tar.gz
git-606417bc6dba270ea2b0867cd490c2b57cb3bfa8.tar.bz2
builtin-mailinfo.c: fix confusing internal API to mailinfo()
It fed two arguments to override the corresponding global variables, but the caller always assigned the values to the global variables first and then passed those global variables to this function. Stop pretending to be a proper API to confuse people. Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rw-r--r--builtin-mailinfo.c7
1 files changed, 2 insertions, 5 deletions
diff --git a/builtin-mailinfo.c b/builtin-mailinfo.c
index b0b5d8f..50326d9 100644
--- a/builtin-mailinfo.c
+++ b/builtin-mailinfo.c
@@ -885,12 +885,9 @@ static void handle_info(void)
fprintf(fout, "\n");
}
-static int mailinfo(FILE *in, FILE *out, int ks, const char *encoding,
- const char *msg, const char *patch)
+static int mailinfo(FILE *in, FILE *out, const char *msg, const char *patch)
{
int peek;
- keep_subject = ks;
- metainfo_charset = encoding;
fin = in;
fout = out;
@@ -956,5 +953,5 @@ int cmd_mailinfo(int argc, const char **argv, const char *prefix)
if (argc != 3)
usage(mailinfo_usage);
- return !!mailinfo(stdin, stdout, keep_subject, metainfo_charset, argv[1], argv[2]);
+ return !!mailinfo(stdin, stdout, argv[1], argv[2]);
}