diff options
| author | Jeff King <peff@peff.net> | 2014-09-13 20:19:38 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2014-09-15 18:39:54 (GMT) |
| commit | 3907a4078a89cffde2e2e0e61a3bd41efba96c49 (patch) | |
| tree | bd5ad6621db53131f3e3362b1f5a0fe21256594b | |
| parent | d38379ece9216735ecc0ffd76c4c4e3da217daec (diff) | |
| download | git-3907a4078a89cffde2e2e0e61a3bd41efba96c49.zip git-3907a4078a89cffde2e2e0e61a3bd41efba96c49.tar.gz git-3907a4078a89cffde2e2e0e61a3bd41efba96c49.tar.bz2 | |
server-info: clean up after writing info/packs
We allocate pack information in a static global list but
never clean it up. This leaks memory, and means that calling
update_server_info twice will generate a buggy file (it will
have duplicate entries).
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | server-info.c | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/server-info.c b/server-info.c index d54a3d6..31f4a74 100644 --- a/server-info.c +++ b/server-info.c @@ -233,6 +233,14 @@ static void init_pack_info(const char *infofile, int force) info[i]->new_num = i; } +static void free_pack_info(void) +{ + int i; + for (i = 0; i < num_pack; i++) + free(info[i]); + free(info); +} + static int write_pack_info_file(FILE *fp) { int i; @@ -252,6 +260,7 @@ static int update_info_packs(int force) init_pack_info(infofile, force); ret = update_info_file(infofile, write_pack_info_file); + free_pack_info(); free(infofile); return ret; } |