diff options
| author | Elia Pinto <gitter.spiros@gmail.com> | 2016-01-12 10:45:12 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2016-01-12 19:47:27 (GMT) |
| commit | 32858a01506b22963cfd5f8c8db95486f26133af (patch) | |
| tree | 6ca3bbc5a9b913892a2df4e20c1d4e6524078262 | |
| parent | cd914d8090d64c8df1b0c45327de7dacdf370a09 (diff) | |
| download | git-32858a01506b22963cfd5f8c8db95486f26133af.zip git-32858a01506b22963cfd5f8c8db95486f26133af.tar.gz git-32858a01506b22963cfd5f8c8db95486f26133af.tar.bz2 | |
t9105-git-svn-commit-diff.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command
substitution instead of using the backquotes `...`.
The backquoted form is the traditional method for command
substitution, and is supported by POSIX. However, all but the
simplest uses become complicated quickly. In particular, embedded
command substitutions and/or the use of double quotes require
careful escaping with the backslash character.
The patch was generated by:
for _f in $(find . -name "*.sh")
do
perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}"
done
and then carefully proof-read.
Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rwxr-xr-x | t/t9105-git-svn-commit-diff.sh | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/t/t9105-git-svn-commit-diff.sh b/t/t9105-git-svn-commit-diff.sh index 5d0afea..6ed5f74 100755 --- a/t/t9105-git-svn-commit-diff.sh +++ b/t/t9105-git-svn-commit-diff.sh @@ -18,8 +18,8 @@ test_expect_success 'initialize repo' ' git commit -a -m "another" ' -head=`git rev-parse --verify HEAD^0` -prev=`git rev-parse --verify HEAD^1` +head=$(git rev-parse --verify HEAD^0) +prev=$(git rev-parse --verify HEAD^1) # the internals of the commit-diff command are the same as the regular # commit, so only a basic test of functionality is needed since we've |