diff options
| author | Jonathan Nieder <jrnieder@gmail.com> | 2010-03-21 02:01:20 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2010-03-21 02:25:48 (GMT) |
| commit | 28db756feead84929cdfaaee8bccd301384daab4 (patch) | |
| tree | 9b37553d3d40a0d238cd4ce10e47a96f03d9d920 | |
| parent | 8e75abfd8dc6649d800b8877304eaa0fd404c10f (diff) | |
| download | git-28db756feead84929cdfaaee8bccd301384daab4.zip git-28db756feead84929cdfaaee8bccd301384daab4.tar.gz git-28db756feead84929cdfaaee8bccd301384daab4.tar.bz2 | |
revert: fix tiny memory leak in cherry-pick --ff
We forgot to free defmsg when returning early for a fast-forward.
Fixing this should reduce noise during test suite runs with valgrind.
More importantly, once cherry-pick learns to pick multiple commits,
the amount of memory leaked would start to add up.
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | builtin-revert.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/builtin-revert.c b/builtin-revert.c index 476f41e..9a3c14c 100644 --- a/builtin-revert.c +++ b/builtin-revert.c @@ -274,7 +274,7 @@ static int revert_or_cherry_pick(int argc, const char **argv) int i, index_fd, clean; char *oneline, *reencoded_message = NULL; const char *message, *encoding; - char *defmsg = git_pathdup("MERGE_MSG"); + char *defmsg = NULL; struct merge_options o; struct tree *result, *next_tree, *base_tree, *head_tree; static struct lock_file index_lock; @@ -364,6 +364,7 @@ static int revert_or_cherry_pick(int argc, const char **argv) * reverse of it if we are revert. */ + defmsg = git_pathdup("MERGE_MSG"); msg_fd = hold_lock_file_for_update(&msg_file, defmsg, LOCK_DIE_ON_ERROR); |