diff options
| author | Shawn O. Pearce <spearce@spearce.org> | 2009-11-09 18:10:37 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2009-11-10 00:41:13 (GMT) |
| commit | 203666352f36702a8773ab47f67ef467528245ae (patch) | |
| tree | 8eb480460cfdfae74fd3cee60371cce6194048d3 | |
| parent | 0a8fcbdca28f6c8dad3cac9aca48f866c84b0f11 (diff) | |
| download | git-203666352f36702a8773ab47f67ef467528245ae.zip git-203666352f36702a8773ab47f67ef467528245ae.tar.gz git-203666352f36702a8773ab47f67ef467528245ae.tar.bz2 | |
t5551-http-fetch: Work around broken Accept header in libcurl
Unfortunately at least one version of libcurl has a bug causing
it to include "Accept: */*" in the same POST request where we have
already asked for "Accept: application/x-git-upload-pack-response".
This is a bug in libcurl, not Git, or our test vector. The
application has explicitly asked the server for a single content
type, but libcurl has mistakenly also told the server the client
application will accept */*, which is any content type.
Based on the libcurl change log, this "Accept: */*" header bug
may have been fixed in version 7.18.1 released March 30, 2008:
http://curl.haxx.se/changes.html#7_18_1
Rather than require users to upgrade libcurl we change the test
vector to trim this line out of the 2nd request.
Reported-by: Tarmigan <tarmigan+git@gmail.com>
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rwxr-xr-x | t/t5551-http-fetch.sh | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/t/t5551-http-fetch.sh b/t/t5551-http-fetch.sh index 0bf165b..c0505ec 100755 --- a/t/t5551-http-fetch.sh +++ b/t/t5551-http-fetch.sh @@ -61,6 +61,9 @@ test_expect_success 'clone http repository' ' /^> User-Agent: /d /^> Host: /d + /^> POST /,$ { + /^> Accept: [*]\\/[*]/d + } s/^> Content-Length: .*/> Content-Length: xxx/ /^> 00..want /d /^> 00.*done/d |