summaryrefslogtreecommitdiff
path: root/t/t7504-commit-msg-hook.sh
blob: 31b9c6a2c1d3c30aa7d6d8a2eb836e7b67831d0c (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
#!/bin/sh
 
test_description='commit-msg hook'
 
. ./test-lib.sh
 
test_expect_success 'with no hook' '
 
	echo "foo" > file &&
	git add file &&
	git commit -m "first"
 
'
 
# set up fake editor for interactive editing
cat > fake-editor <<'EOF'
#!/bin/sh
cp FAKE_MSG "$1"
exit 0
EOF
chmod +x fake-editor
 
## Not using test_set_editor here so we can easily ensure the editor variable
## is only set for the editor tests
FAKE_EDITOR="$(pwd)/fake-editor"
export FAKE_EDITOR
 
test_expect_success 'with no hook (editor)' '
 
	echo "more foo" >> file &&
	git add file &&
	echo "more foo" > FAKE_MSG &&
	GIT_EDITOR="\"\$FAKE_EDITOR\"" git commit
 
'
 
test_expect_success '--no-verify with no hook' '
 
	echo "bar" > file &&
	git add file &&
	git commit --no-verify -m "bar"
 
'
 
test_expect_success '--no-verify with no hook (editor)' '
 
	echo "more bar" > file &&
	git add file &&
	echo "more bar" > FAKE_MSG &&
	GIT_EDITOR="\"\$FAKE_EDITOR\"" git commit --no-verify
 
'
 
# now install hook that always succeeds
HOOKDIR="$(git rev-parse --git-dir)/hooks"
HOOK="$HOOKDIR/commit-msg"
mkdir -p "$HOOKDIR"
cat > "$HOOK" <<EOF
#!/bin/sh
exit 0
EOF
chmod +x "$HOOK"
 
test_expect_success 'with succeeding hook' '
 
	echo "more" >> file &&
	git add file &&
	git commit -m "more"
 
'
 
test_expect_success 'with succeeding hook (editor)' '
 
	echo "more more" >> file &&
	git add file &&
	echo "more more" > FAKE_MSG &&
	GIT_EDITOR="\"\$FAKE_EDITOR\"" git commit
 
'
 
test_expect_success '--no-verify with succeeding hook' '
 
	echo "even more" >> file &&
	git add file &&
	git commit --no-verify -m "even more"
 
'
 
test_expect_success '--no-verify with succeeding hook (editor)' '
 
	echo "even more more" >> file &&
	git add file &&
	echo "even more more" > FAKE_MSG &&
	GIT_EDITOR="\"\$FAKE_EDITOR\"" git commit --no-verify
 
'
 
# now a hook that fails
cat > "$HOOK" <<EOF
#!/bin/sh
exit 1
EOF
 
commit_msg_is () {
	test "$(git log --pretty=format:%s%b -1)" = "$1"
}
 
test_expect_success 'with failing hook' '
 
	echo "another" >> file &&
	git add file &&
	test_must_fail git commit -m "another"
 
'
 
test_expect_success 'with failing hook (editor)' '
 
	echo "more another" >> file &&
	git add file &&
	echo "more another" > FAKE_MSG &&
	! (GIT_EDITOR="\"\$FAKE_EDITOR\"" git commit)
 
'
 
test_expect_success '--no-verify with failing hook' '
 
	echo "stuff" >> file &&
	git add file &&
	git commit --no-verify -m "stuff"
 
'
 
test_expect_success '--no-verify with failing hook (editor)' '
 
	echo "more stuff" >> file &&
	git add file &&
	echo "more stuff" > FAKE_MSG &&
	GIT_EDITOR="\"\$FAKE_EDITOR\"" git commit --no-verify
 
'
 
test_expect_success 'merge fails with failing hook' '
 
	test_when_finished "git branch -D newbranch" &&
	test_when_finished "git checkout -f master" &&
	git checkout --orphan newbranch &&
	: >file2 &&
	git add file2 &&
	git commit --no-verify file2 -m in-side-branch &&
	test_must_fail git merge --allow-unrelated-histories master &&
	commit_msg_is "in-side-branch" # HEAD before merge
 
'
 
test_expect_success 'merge bypasses failing hook with --no-verify' '
 
	test_when_finished "git branch -D newbranch" &&
	test_when_finished "git checkout -f master" &&
	git checkout --orphan newbranch &&
	git rm -f file &&
	: >file2 &&
	git add file2 &&
	git commit --no-verify file2 -m in-side-branch &&
	git merge --no-verify --allow-unrelated-histories master &&
	commit_msg_is "Merge branch '\''master'\'' into newbranch"
'
 
 
chmod -x "$HOOK"
test_expect_success POSIXPERM 'with non-executable hook' '
 
	echo "content" >file &&
	git add file &&
	git commit -m "content"
 
'
 
test_expect_success POSIXPERM 'with non-executable hook (editor)' '
 
	echo "content again" >> file &&
	git add file &&
	echo "content again" > FAKE_MSG &&
	GIT_EDITOR="\"\$FAKE_EDITOR\"" git commit -m "content again"
 
'
 
test_expect_success POSIXPERM '--no-verify with non-executable hook' '
 
	echo "more content" >> file &&
	git add file &&
	git commit --no-verify -m "more content"
 
'
 
test_expect_success POSIXPERM '--no-verify with non-executable hook (editor)' '
 
	echo "even more content" >> file &&
	git add file &&
	echo "even more content" > FAKE_MSG &&
	GIT_EDITOR="\"\$FAKE_EDITOR\"" git commit --no-verify
 
'
 
# now a hook that edits the commit message
cat > "$HOOK" <<'EOF'
#!/bin/sh
echo "new message" > "$1"
exit 0
EOF
chmod +x "$HOOK"
 
test_expect_success 'hook edits commit message' '
 
	echo "additional" >> file &&
	git add file &&
	git commit -m "additional" &&
	commit_msg_is "new message"
 
'
 
test_expect_success 'hook edits commit message (editor)' '
 
	echo "additional content" >> file &&
	git add file &&
	echo "additional content" > FAKE_MSG &&
	GIT_EDITOR="\"\$FAKE_EDITOR\"" git commit &&
	commit_msg_is "new message"
 
'
 
test_expect_success "hook doesn't edit commit message" '
 
	echo "plus" >> file &&
	git add file &&
	git commit --no-verify -m "plus" &&
	commit_msg_is "plus"
 
'
 
test_expect_success "hook doesn't edit commit message (editor)" '
 
	echo "more plus" >> file &&
	git add file &&
	echo "more plus" > FAKE_MSG &&
	GIT_EDITOR="\"\$FAKE_EDITOR\"" git commit --no-verify &&
	commit_msg_is "more plus"
'
 
test_expect_success 'hook called in git-merge picks up commit message' '
	test_when_finished "git branch -D newbranch" &&
	test_when_finished "git checkout -f master" &&
	git checkout --orphan newbranch &&
	git rm -f file &&
	: >file2 &&
	git add file2 &&
	git commit --no-verify file2 -m in-side-branch &&
	git merge --allow-unrelated-histories master &&
	commit_msg_is "new message"
'
 
test_expect_failure 'merge --continue remembers --no-verify' '
	test_when_finished "git branch -D newbranch" &&
	test_when_finished "git checkout -f master" &&
	git checkout master &&
	echo a >file2 &&
	git add file2 &&
	git commit --no-verify -m "add file2 to master" &&
	git checkout -b newbranch master^ &&
	echo b >file2 &&
	git add file2 &&
	git commit --no-verify file2 -m in-side-branch &&
	git merge --no-verify -m not-rewritten-by-hook master &&
	# resolve conflict:
	echo c >file2 &&
	git add file2 &&
	git merge --continue &&
	commit_msg_is not-rewritten-by-hook
'
 
# set up fake editor to replace `pick` by `reword`
cat > reword-editor <<'EOF'
#!/bin/sh
mv "$1" "$1".bup &&
sed 's/^pick/reword/' <"$1".bup >"$1"
EOF
chmod +x reword-editor
REWORD_EDITOR="$(pwd)/reword-editor"
export REWORD_EDITOR
 
test_expect_success 'hook is called for reword during `rebase -i`' '
 
	GIT_SEQUENCE_EDITOR="\"$REWORD_EDITOR\"" git rebase -i HEAD^ &&
	commit_msg_is "new message"
 
'
 
 
test_done