From c105f563d1b8894af8a7bee68852e45831d55224 Mon Sep 17 00:00:00 2001 From: Christian Couder Date: Thu, 30 Mar 2017 08:22:08 +0200 Subject: update-index: fix xgetcwd() related memory leak As xgetcwd() returns an allocated buffer, we should free this buffer when we don't need it any more. This was found by Coverity. Reported-by: Jeff King Signed-off-by: Christian Couder Signed-off-by: Junio C Hamano diff --git a/builtin/update-index.c b/builtin/update-index.c index 7a55334..984fe37 100644 --- a/builtin/update-index.c +++ b/builtin/update-index.c @@ -125,12 +125,16 @@ static int test_if_untracked_cache_is_supported(void) struct stat st; struct stat_data base; int fd, ret = 0; + char *cwd; strbuf_addstr(&mtime_dir, "mtime-test-XXXXXX"); if (!mkdtemp(mtime_dir.buf)) die_errno("Could not make temporary directory"); - fprintf(stderr, _("Testing mtime in '%s' "), xgetcwd()); + cwd = xgetcwd(); + fprintf(stderr, _("Testing mtime in '%s' "), cwd); + free(cwd); + atexit(remove_test_directory); xstat_mtime_dir(&st); fill_stat_data(&base, &st); -- cgit v0.10.2-6-g49f6