From 362b0dd523f5162e7c55c76b5d0af7ad830e0e83 Mon Sep 17 00:00:00 2001 From: Dan McGee Date: Sat, 26 Apr 2008 19:43:20 -0500 Subject: Remove 'header' from --signoff option description Signed-off-by: Dan McGee Signed-off-by: Junio C Hamano diff --git a/builtin-commit.c b/builtin-commit.c index a228a43..a2da314 100644 --- a/builtin-commit.c +++ b/builtin-commit.c @@ -89,7 +89,7 @@ static struct option builtin_commit_options[] = { OPT_CALLBACK('m', "message", &message, "MESSAGE", "specify commit message", opt_parse_m), OPT_STRING('c', "reedit-message", &edit_message, "COMMIT", "reuse and edit message from specified commit "), OPT_STRING('C', "reuse-message", &use_message, "COMMIT", "reuse message from specified commit"), - OPT_BOOLEAN('s', "signoff", &signoff, "add Signed-off-by: header"), + OPT_BOOLEAN('s', "signoff", &signoff, "add Signed-off-by:"), OPT_STRING('t', "template", &template_file, "FILE", "use specified template file"), OPT_BOOLEAN('e', "edit", &edit_flag, "force edit of commit"), -- cgit v0.10.2-6-g49f6 From a2b26acd7afb4d77d8844ccd681e993f25e75205 Mon Sep 17 00:00:00 2001 From: Junio C Hamano Date: Wed, 23 Apr 2008 10:53:47 -0700 Subject: clone: detect and fail on excess parameters "git clone [options] $src $dst excess-garbage" simply ignored excess-garbage without giving any diagnostic message. Fix it. Signed-off-by: Junio C Hamano diff --git a/git-clone.sh b/git-clone.sh index 2636159..9e433c0 100755 --- a/git-clone.sh +++ b/git-clone.sh @@ -219,6 +219,7 @@ fi if test -n "$2" then dir="$2" + test $# == 2 || die "excess parameter to git-clone" else # Derive one from the repository name # Try using "humanish" part of source repo if user didn't specify one diff --git a/t/t5601-clone.sh b/t/t5601-clone.sh new file mode 100755 index 0000000..dc9d63d --- /dev/null +++ b/t/t5601-clone.sh @@ -0,0 +1,26 @@ +#!/bin/sh + +test_description=clone + +. ./test-lib.sh + +test_expect_success setup ' + + rm -fr .git && + test_create_repo src && + ( + cd src + >file + git add file + git commit -m initial + ) + +' + +test_expect_success 'clone with excess parameters' ' + + test_must_fail git clone -n "file://$(pwd)/src" dst junk + +' + +test_done -- cgit v0.10.2-6-g49f6