From 5a06a20e0c8820fb0ca8da019c7a9fe6eb30ec2f Mon Sep 17 00:00:00 2001 From: Ben Peart Date: Thu, 12 Jul 2018 15:44:36 +0000 Subject: handle lower case drive letters on Windows On Windows, if a tool calls SetCurrentDirectory with a lower case drive letter, the subsequent call to GetCurrentDirectory will return the same lower case drive letter. Powershell, for example, does not normalize the path. If that happens, test-drop-caches will error out as it does not correctly to handle lower case drive letters. Helped-by: Johannes Schindelin Signed-off-by: Ben Peart Signed-off-by: Junio C Hamano diff --git a/t/helper/test-drop-caches.c b/t/helper/test-drop-caches.c index d6bcfdd..f65e301 100644 --- a/t/helper/test-drop-caches.c +++ b/t/helper/test-drop-caches.c @@ -16,8 +16,8 @@ static int cmd_sync(void) if ((0 == dwRet) || (dwRet > MAX_PATH)) return error("Error getting current directory"); - if ((Buffer[0] < 'A') || (Buffer[0] > 'Z')) - return error("Invalid drive letter '%c'", Buffer[0]); + if (!has_dos_drive_prefix(Buffer)) + return error("'%s': invalid drive letter", Buffer); szVolumeAccessPath[4] = Buffer[0]; hVolWrite = CreateFile(szVolumeAccessPath, GENERIC_READ | GENERIC_WRITE, -- cgit v0.10.2-6-g49f6