From bf4a60874af992655c139c612c06758353495e3b Mon Sep 17 00:00:00 2001 From: Taylor Blau Date: Fri, 17 Sep 2021 17:21:27 -0400 Subject: p5326: generate pack bitmaps before writing the MIDX bitmap To help test the performance of permuting the contents of the hash-cache when generating a MIDX bitmap, we need a bitmap which has its hash-cache populated. And since multi-pack bitmaps don't add *new* values to the hash-cache, we have to rely on a single-pack bitmap to generate those values for us. Therefore, generate a pack bitmap before the MIDX one in order to ensure that the MIDX bitmap has entries in its hash-cache. Since we don't want to time generating the pack bitmap, move that to a non-perf test run before we try to generate the MIDX bitmap. Likewise, get rid of the pack bitmap afterwords, to make certain that we are not accidentally using it in the performance tests run later on. Signed-off-by: Taylor Blau Signed-off-by: Junio C Hamano diff --git a/t/perf/p5326-multi-pack-bitmaps.sh b/t/perf/p5326-multi-pack-bitmaps.sh index a9c5499..f2fa228 100755 --- a/t/perf/p5326-multi-pack-bitmaps.sh +++ b/t/perf/p5326-multi-pack-bitmaps.sh @@ -12,11 +12,18 @@ test_expect_success 'create tags' ' git tag --message="tag pointing to HEAD" perf-tag HEAD ' +test_expect_success 'start with bitmapped pack' ' + git repack -adb +' + test_perf 'setup multi-pack index' ' - git repack -ad && git multi-pack-index write --bitmap ' +test_expect_success 'drop pack bitmap' ' + rm -f .git/objects/pack/pack-*.bitmap +' + test_full_bitmap test_expect_success 'create partial bitmap state' ' -- cgit v0.10.2-6-g49f6