From 2e0afafebd8c5a1a8cdddb0714073461229ecfef Mon Sep 17 00:00:00 2001 From: Johannes Schindelin Date: Thu, 22 Feb 2007 01:59:14 +0100 Subject: Add git-bundle: move objects and references by archive Some workflows require use of repositories on machines that cannot be connected, preventing use of git-fetch / git-push to transport objects and references between the repositories. git-bundle provides an alternate transport mechanism, effectively allowing git-fetch and git-pull to operate using sneakernet transport. `git-bundle create` allows the user to create a bundle containing one or more branches or tags, but with specified basis assumed to exist on the target repository. At the receiving end, git-bundle acts like git-fetch-pack, allowing the user to invoke git-fetch or git-pull using the bundle file as the URL. git-fetch and git-ls-remote determine they have a bundle URL by checking that the URL points to a file, but are otherwise unchanged in operation with bundles. The original patch was done by Mark Levedahl . It was updated to make git-bundle a builtin, and get rid of the tar format: now, the first line is supposed to say "# v2 git bundle", the next lines either contain a prerequisite ("-" followed by the hash of the needed commit), or a ref (the hash of a commit, followed by the name of the ref), and finally the pack. As a result, the bundle argument can be "-" now. Signed-off-by: Johannes Schindelin Signed-off-by: Junio C Hamano diff --git a/.gitignore b/.gitignore index d99372a..9c912c1 100644 --- a/.gitignore +++ b/.gitignore @@ -13,6 +13,7 @@ git-archive git-bisect git-blame git-branch +git-bundle git-cat-file git-check-ref-format git-checkout diff --git a/Documentation/cmd-list.perl b/Documentation/cmd-list.perl index 69003e9..29f81f6 100755 --- a/Documentation/cmd-list.perl +++ b/Documentation/cmd-list.perl @@ -70,6 +70,7 @@ git-archive mainporcelain git-bisect mainporcelain git-blame ancillaryinterrogators git-branch mainporcelain +git-bundle mainporcelain git-cat-file plumbinginterrogators git-checkout-index plumbingmanipulators git-checkout mainporcelain diff --git a/Documentation/git-bundle.txt b/Documentation/git-bundle.txt new file mode 100644 index 0000000..4ea9e85 --- /dev/null +++ b/Documentation/git-bundle.txt @@ -0,0 +1,139 @@ +git-bundle(1) +============= + +NAME +---- +git-bundle - Move objects and refs by archive + + +SYNOPSIS +-------- +'git-bundle' create [git-rev-list args] +'git-bundle' verify +'git-bundle' list-heads [refname...] +'git-bundle' unbundle [refname...] + +DESCRIPTION +----------- + +Some workflows require that one or more branches of development on one +machine be replicated on another machine, but the two machines cannot +be directly connected so the interactive git protocols (git, ssh, +rsync, http) cannot be used. This command provides suport for +git-fetch and git-pull to operate by packaging objects and references +in an archive at the originating machine, then importing those into +another repository using gitlink:git-fetch[1] and gitlink:git-pull[1] +after moving the archive by some means (i.e., by sneakernet). As no +direct connection between repositories exists, the user must specify a +basis for the bundle that is held by the destination repository: the +bundle assumes that all objects in the basis are already in the +destination repository. + +OPTIONS +------- + +create :: + Used to create a bundle named 'file'. This requires the + git-rev-list arguments to define the bundle contents. + +verify :: + Used to check that a bundle file is valid and will apply + cleanly to the current repository. This includes checks on the + bundle format itself as well as checking that the prerequisite + commits exist and are fully linked in the current repository. + git-bundle prints a list of missing commits, if any, and exits + with non-zero status. + +list-heads :: + Lists the references defined in the bundle. If followed by a + list of references, only references matching those given are + printed out. + +unbundle :: + Passes the objects in the bundle to gitlink:git-index-pack[1] + for storage in the repository, then prints the names of all + defined references. If a reflist is given, only references + matching those in the given list are printed. This command is + really plumbing, intended to be called only by + gitlink:git-fetch[1]. + +[git-rev-list-args...]:: + A list of arguments, accepatble to git-rev-parse and + git-rev-list, that specify the specific objects and references + to transport. For example, "master~10..master" causes the + current master reference to be packaged along with all objects + added since its 10th ancestor commit. There is no explicit + limit to the number of references and objects that may be + packaged. + + +[refname...]:: + A list of references used to limit the references reported as + available. This is principally of use to git-fetch, which + expects to recieve only those references asked for and not + necessarily everything in the pack (in this case, git-bundle is + acting like gitlink:git-fetch-pack[1]). + +SPECIFYING REFERENCES +--------------------- + +git-bundle will only package references that are shown by +git-show-ref: this includes heads, tags, and remote heads. References +such as master~1 cannot be packaged, but are perfectly suitable for +defining the basis. More than one reference may be packaged, and more +than one basis can be specified. The objects packaged are those not +contained in the union of the given bases. Each basis can be +specified explicitly (e.g., ^master~10), or implicitly (e.g., +master~10..master, master --since=10.days.ago). + +It is very important that the basis used be held by the destination. +It is ok to err on the side of conservatism, causing the bundle file +to contain objects already in the destination as these are ignored +when unpacking at the destination. + +EXAMPLE +------- + +Assume two repositories exist as R1 on machine A, and R2 on machine B. +For whatever reason, direct connection between A and B is not allowed, +but we can move data from A to B via some mechanism (CD, email, etc). +We want to update R2 with developments made on branch master in R1. +We set a tag in R1 (lastR2bundle) after the previous such transport, +and move it afterwards to help build the bundle. + +in R1 on A: +$ git-bundle create mybundle master ^lastR2bundle +$ git tag -f lastR2bundle master + +(move mybundle from A to B by some mechanism) + +in R2 on B: +$ git-bundle verify mybundle +$ git-fetch mybundle refspec + +where refspec is refInBundle:localRef + + +Also, with something like this in your config: + +[remote "bundle"] + url = /home/me/tmp/file.bdl + fetch = refs/heads/*:refs/remotes/origin/* + +You can first sneakernet the bundle file to ~/tmp/file.bdl and +then these commands: + +$ git ls-remote bundle +$ git fetch bundle +$ git pull bundle + +would treat it as if it is talking with a remote side over the +network. + +Author +------ +Written by Mark Levedahl + +GIT +--- +Part of the gitlink:git[7] suite diff --git a/Makefile b/Makefile index 40bdcff..a786941 100644 --- a/Makefile +++ b/Makefile @@ -271,6 +271,7 @@ BUILTIN_OBJS = \ builtin-archive.o \ builtin-blame.o \ builtin-branch.o \ + builtin-bundle.o \ builtin-cat-file.o \ builtin-checkout-index.o \ builtin-check-ref-format.o \ diff --git a/builtin-bundle.c b/builtin-bundle.c new file mode 100644 index 0000000..4bd596a --- /dev/null +++ b/builtin-bundle.c @@ -0,0 +1,389 @@ +#include "cache.h" +#include "object.h" +#include "commit.h" +#include "diff.h" +#include "revision.h" +#include "list-objects.h" +#include "exec_cmd.h" + +/* + * Basic handler for bundle files to connect repositories via sneakernet. + * Invocation must include action. + * This function can create a bundle or provide information on an existing + * bundle supporting git-fetch, git-pull, and git-ls-remote + */ + +static const char *bundle_usage="git-bundle (--create | --verify | --list-heads [refname]... | --unbundle [refname]... )"; + +static const char bundle_signature[] = "# v2 git bundle\n"; + +struct ref_list { + unsigned int nr, alloc; + struct { + unsigned char sha1[20]; + char *name; + } *list; +}; + +static void add_to_ref_list(const unsigned char *sha1, const char *name, + struct ref_list *list) +{ + if (list->nr + 1 >= list->alloc) { + list->alloc = alloc_nr(list->nr + 1); + list->list = xrealloc(list->list, + list->alloc * sizeof(list->list[0])); + } + memcpy(list->list[list->nr].sha1, sha1, 20); + list->list[list->nr].name = xstrdup(name); + list->nr++; +} + +struct bundle_header { + struct ref_list prerequisites, references; +}; + +/* this function returns the length of the string */ +static int read_string(int fd, char *buffer, int size) +{ + int i; + for (i = 0; i < size - 1; i++) { + int count = read(fd, buffer + i, 1); + if (count < 0) + return error("Read error: %s", strerror(errno)); + if (count == 0) { + i--; + break; + } + if (buffer[i] == '\n') + break; + } + buffer[i + 1] = '\0'; + return i + 1; +} + +/* returns an fd */ +static int read_header(const char *path, struct bundle_header *header) { + char buffer[1024]; + int fd = open(path, O_RDONLY); + + if (fd < 0) + return error("could not open '%s'", path); + if (read_string(fd, buffer, sizeof(buffer)) < 0 || + strcmp(buffer, bundle_signature)) { + close(fd); + return error("'%s' does not look like a v2 bundle file", path); + } + while (read_string(fd, buffer, sizeof(buffer)) > 0 + && buffer[0] != '\n') { + int offset = buffer[0] == '-' ? 1 : 0; + int len = strlen(buffer); + unsigned char sha1[20]; + struct ref_list *list = offset ? &header->prerequisites + : &header->references; + if (get_sha1_hex(buffer + offset, sha1)) { + close(fd); + return error("invalid SHA1: %s", buffer); + } + if (buffer[len - 1] == '\n') + buffer[len - 1] = '\0'; + add_to_ref_list(sha1, buffer + 41 + offset, list); + } + return fd; +} + +/* if in && *in >= 0, take that as input file descriptor instead */ +static int fork_with_pipe(const char **argv, int *in, int *out) +{ + int needs_in, needs_out; + int fdin[2], fdout[2], pid; + + needs_in = in && *in < 0; + if (needs_in) { + if (pipe(fdin) < 0) + return error("could not setup pipe"); + *in = fdin[1]; + } + + needs_out = out && *out < 0; + if (needs_out) { + if (pipe(fdout) < 0) + return error("could not setup pipe"); + *out = fdout[0]; + } + + if ((pid = fork()) < 0) { + if (needs_in) { + close(fdin[0]); + close(fdin[1]); + } + if (needs_out) { + close(fdout[0]); + close(fdout[1]); + } + return error("could not fork"); + } + if (!pid) { + if (needs_in) { + dup2(fdin[0], 0); + close(fdin[0]); + close(fdin[1]); + } else if (in) + dup2(*in, 0); + if (needs_out) { + dup2(fdout[1], 1); + close(fdout[0]); + close(fdout[1]); + } else if (out) + dup2(*out, 1); + exit(execv_git_cmd(argv)); + } + if (needs_in) + close(fdin[0]); + if (needs_out) + close(fdout[1]); + return pid; +} + +static int verify_bundle(struct bundle_header *header) +{ + /* + * Do fast check, then if any prereqs are missing then go line by line + * to be verbose about the errors + */ + struct ref_list *p = &header->prerequisites; + const char *argv[5] = {"rev-list", "--stdin", "--not", "--all", NULL}; + int pid, in, out, i, ret = 0; + char buffer[1024]; + + in = out = -1; + pid = fork_with_pipe(argv, &in, &out); + if (pid < 0) + return error("Could not fork rev-list"); + if (!fork()) { + for (i = 0; i < p->nr; i++) { + write(in, sha1_to_hex(p->list[i].sha1), 40); + write(in, "\n", 1); + } + close(in); + exit(0); + } + close(in); + while (read_string(out, buffer, sizeof(buffer)) > 0) { + if (ret++ == 0) + error ("The bundle requires the following commits you lack:"); + fprintf(stderr, "%s", buffer); + } + close(out); + while (waitpid(pid, &i, 0) < 0) + if (errno != EINTR) + return -1; + if (!ret && (!WIFEXITED(i) || WEXITSTATUS(i))) + return error("At least one prerequisite is lacking."); + + return ret; +} + +static int list_heads(struct bundle_header *header, int argc, const char **argv) +{ + int i; + struct ref_list *r = &header->references; + + for (i = 0; i < r->nr; i++) { + if (argc > 1) { + int j; + for (j = 1; j < argc; j++) + if (!strcmp(r->list[i].name, argv[j])) + break; + if (j == argc) + continue; + } + printf("%s %s\n", sha1_to_hex(r->list[i].sha1), + r->list[i].name); + } + return 0; +} + +static void show_commit(struct commit *commit) +{ + write(1, sha1_to_hex(commit->object.sha1), 40); + write(1, "\n", 1); + if (commit->parents) { + free_commit_list(commit->parents); + commit->parents = NULL; + } +} + +static void show_object(struct object_array_entry *p) +{ + /* An object with name "foo\n0000000..." can be used to + * * confuse downstream git-pack-objects very badly. + * */ + const char *ep = strchr(p->name, '\n'); + int len = ep ? ep - p->name : strlen(p->name); + write(1, sha1_to_hex(p->item->sha1), 40); + write(1, " ", 1); + if (len) + write(1, p->name, len); + write(1, "\n", 1); +} + +static int create_bundle(struct bundle_header *header, const char *path, + int argc, const char **argv) +{ + int bundle_fd = -1; + const char **argv_boundary = xmalloc((argc + 3) * sizeof(const char *)); + const char **argv_pack = xmalloc(4 * sizeof(const char *)); + int pid, in, out, i, status; + char buffer[1024]; + struct rev_info revs; + + bundle_fd = (!strcmp(path, "-") ? 1 : + open(path, O_CREAT | O_WRONLY, 0666)); + if (bundle_fd < 0) + return error("Could not write to '%s'", path); + + /* write signature */ + write(bundle_fd, bundle_signature, strlen(bundle_signature)); + + /* write prerequisites */ + memcpy(argv_boundary + 2, argv + 1, argc * sizeof(const char *)); + argv_boundary[0] = "rev-list"; + argv_boundary[1] = "--boundary"; + argv_boundary[argc + 1] = NULL; + out = -1; + pid = fork_with_pipe(argv_boundary, NULL, &out); + if (pid < 0) + return -1; + while ((i = read_string(out, buffer, sizeof(buffer))) > 0) + if (buffer[0] == '-') + write(bundle_fd, buffer, i); + while ((i = waitpid(pid, &status, 0)) < 0) + if (errno != EINTR) + return error("rev-list died"); + if (!WIFEXITED(status) || WEXITSTATUS(status)) + return error("rev-list died %d", WEXITSTATUS(status)); + + /* write references */ + save_commit_buffer = 0; + init_revisions(&revs, NULL); + revs.tag_objects = 1; + revs.tree_objects = 1; + revs.blob_objects = 1; + argc = setup_revisions(argc, argv, &revs, NULL); + if (argc > 1) + return error("unrecognized argument: %s'", argv[1]); + for (i = 0; i < revs.pending.nr; i++) { + struct object_array_entry *e = revs.pending.objects + i; + if (!(e->item->flags & UNINTERESTING)) { + unsigned char sha1[20]; + char *ref; + if (dwim_ref(e->name, strlen(e->name), sha1, &ref) != 1) + continue; + write(bundle_fd, sha1_to_hex(e->item->sha1), 40); + write(bundle_fd, " ", 1); + write(bundle_fd, ref, strlen(ref)); + write(bundle_fd, "\n", 1); + free(ref); + } + } + + /* end header */ + write(bundle_fd, "\n", 1); + + /* write pack */ + argv_pack[0] = "pack-objects"; + argv_pack[1] = "--all-progress"; + argv_pack[2] = "--stdout"; + argv_pack[3] = NULL; + in = -1; + out = bundle_fd; + pid = fork_with_pipe(argv_pack, &in, &out); + if (pid < 0) + return error("Could not spawn pack-objects"); + close(1); + close(bundle_fd); + dup2(in, 1); + close(in); + prepare_revision_walk(&revs); + traverse_commit_list(&revs, show_commit, show_object); + close(1); + while (waitpid(pid, &status, 0) < 0) + if (errno != EINTR) + return -1; + if (!WIFEXITED(status) || WEXITSTATUS(status)) + return error ("pack-objects died"); + return 0; +} + +static int unbundle(struct bundle_header *header, int bundle_fd, + int argc, const char **argv) +{ + const char *argv_index_pack[] = {"index-pack", "--stdin", NULL}; + int pid, status, dev_null; + + if (verify_bundle(header)) + return -1; + dev_null = open("/dev/null", O_WRONLY); + pid = fork_with_pipe(argv_index_pack, &bundle_fd, &dev_null); + if (pid < 0) + return error("Could not spawn index-pack"); + close(bundle_fd); + while (waitpid(pid, &status, 0) < 0) + if (errno != EINTR) + return error("index-pack died"); + if (!WIFEXITED(status) || WEXITSTATUS(status)) + return error("index-pack exited with status %d", + WEXITSTATUS(status)); + return list_heads(header, argc, argv); +} + +int cmd_bundle(int argc, const char **argv, const char *prefix) +{ + struct bundle_header header; + int nongit = 0; + const char *cmd, *bundle_file; + int bundle_fd = -1; + char buffer[PATH_MAX]; + + if (argc < 3) + usage(bundle_usage); + + cmd = argv[1]; + bundle_file = argv[2]; + argc -= 2; + argv += 2; + + prefix = setup_git_directory_gently(&nongit); + if (prefix && bundle_file[0] != '/') { + snprintf(buffer, sizeof(buffer), "%s/%s", prefix, bundle_file); + bundle_file = buffer; + } + + memset(&header, 0, sizeof(header)); + if (strcmp(cmd, "create") && + !(bundle_fd = read_header(bundle_file, &header))) + return 1; + + if (!strcmp(cmd, "verify")) { + close(bundle_fd); + if (verify_bundle(&header)) + return 1; + fprintf(stderr, "%s is okay\n", bundle_file); + return 0; + } + if (!strcmp(cmd, "list-heads")) { + close(bundle_fd); + return !!list_heads(&header, argc, argv); + } + if (!strcmp(cmd, "create")) { + if (nongit) + die("Need a repository to create a bundle."); + return !!create_bundle(&header, bundle_file, argc, argv); + } else if (!strcmp(cmd, "unbundle")) { + if (nongit) + die("Need a repository to unbundle."); + return !!unbundle(&header, bundle_fd, argc, argv); + } else + usage(bundle_usage); +} + diff --git a/builtin.h b/builtin.h index 5108fd2..8ceb0dc 100644 --- a/builtin.h +++ b/builtin.h @@ -19,6 +19,7 @@ extern int cmd_apply(int argc, const char **argv, const char *prefix); extern int cmd_archive(int argc, const char **argv, const char *prefix); extern int cmd_blame(int argc, const char **argv, const char *prefix); extern int cmd_branch(int argc, const char **argv, const char *prefix); +extern int cmd_bundle(int argc, const char **argv, const char *prefix); extern int cmd_cat_file(int argc, const char **argv, const char *prefix); extern int cmd_checkout_index(int argc, const char **argv, const char *prefix); extern int cmd_check_ref_format(int argc, const char **argv, const char *prefix); diff --git a/git-fetch.sh b/git-fetch.sh index ca984e7..d5b34bc 100755 --- a/git-fetch.sh +++ b/git-fetch.sh @@ -377,8 +377,15 @@ fetch_main () { ( : subshell because we muck with IFS IFS=" $LF" ( + if test -f "$remote" ; then + test -n "$shallow_depth" && + die "shallow clone with bundle is not supported" + git-bundle unbundle "$remote" $rref || + echo failed "$remote" + else git-fetch-pack --thin $exec $keep $shallow_depth "$remote" $rref || echo failed "$remote" + fi ) | ( trap ' diff --git a/git-ls-remote.sh b/git-ls-remote.sh index 8ea5c5e..a6ed99a 100755 --- a/git-ls-remote.sh +++ b/git-ls-remote.sh @@ -89,8 +89,13 @@ rsync://* ) ;; * ) - git-peek-remote $exec "$peek_repo" || + if test -f "$peek_repo" ; then + git bundle list-heads "$peek_repo" || echo "failed slurping" + else + git-peek-remote $exec "$peek_repo" || + echo "failed slurping" + fi ;; esac | sort -t ' ' -k 2 | diff --git a/git.c b/git.c index 45265f1..cfa5799 100644 --- a/git.c +++ b/git.c @@ -229,6 +229,7 @@ static void handle_internal_command(int argc, const char **argv, char **envp) { "archive", cmd_archive }, { "blame", cmd_blame, RUN_SETUP }, { "branch", cmd_branch, RUN_SETUP }, + { "bundle", cmd_bundle }, { "cat-file", cmd_cat_file, RUN_SETUP }, { "checkout-index", cmd_checkout_index, RUN_SETUP }, { "check-ref-format", cmd_check_ref_format }, diff --git a/index-pack.c b/index-pack.c index 72e0962..24bbdcd 100644 --- a/index-pack.c +++ b/index-pack.c @@ -457,8 +457,8 @@ static void parse_pack_objects(unsigned char *sha1) /* If input_fd is a file, we should have reached its end now. */ if (fstat(input_fd, &st)) die("cannot fstat packfile: %s", strerror(errno)); - if (S_ISREG(st.st_mode) && st.st_size != consumed_bytes) - die("pack has junk at the end"); + if (input_fd && S_ISREG(st.st_mode) && st.st_size != consumed_bytes) + die("pack has junk at the end: 0%o, %d, %d %d", st.st_mode, (int)st.st_size, (int)consumed_bytes, input_fd); if (!nr_deltas) return; diff --git a/t/t5510-fetch.sh b/t/t5510-fetch.sh index 50c6485..fa76662 100755 --- a/t/t5510-fetch.sh +++ b/t/t5510-fetch.sh @@ -35,7 +35,9 @@ test_expect_success "clone and setup child repos" ' echo "URL: ../two/.git/" echo "Pull: refs/heads/master:refs/heads/two" echo "Pull: refs/heads/one:refs/heads/one" - } >.git/remotes/two + } >.git/remotes/two && + cd .. && + git clone . bundle ' test_expect_success "fetch test" ' @@ -81,4 +83,28 @@ test_expect_success 'fetch following tags' ' ' +test_expect_success 'create bundle 1' ' + cd "$D" && + echo >file updated again by origin && + git commit -a -m "tip" && + git bundle create bundle1 master^..master +' + +test_expect_success 'create bundle 2' ' + cd "$D" && + git bundle create bundle2 master~2..master +' + +test_expect_failure 'unbundle 1' ' + cd "$D/bundle" && + git checkout -b some-branch && + git fetch "$D/bundle1" master:master +' + +test_expect_success 'unbundle 2' ' + cd "$D/bundle" && + git fetch ../bundle2 master:master && + test "tip" = "$(git log -1 --pretty=oneline master | cut -b42-)" +' + test_done -- cgit v0.10.2-6-g49f6 From fa257b0554d5cea91c2bba98c2017336e0890b36 Mon Sep 17 00:00:00 2001 From: Johannes Schindelin Date: Thu, 22 Feb 2007 19:14:14 +0100 Subject: git-bundle: assorted fixes This patch fixes issues mentioned by Junio, Nico and Simon: - I forgot to convert the usage string when removing the "--" from the subcommands, - a style fix in the bundle_header, - use xread() instead of read(), - use write_or_die() instead of write(), - make the bundle header extensible, - fail if the whitespace after a sha1 of a reference is missing, - close() the fds passed to a subprocess, - in verify_bundle(), do not use "rev-list --stdin", but rather pass the revs directly (avoiding a fork()), - fix a corrupted comment in show_object(), and - fix the size check in index_pack. Signed-off-by: Johannes Schindelin Signed-off-by: Junio C Hamano diff --git a/builtin-bundle.c b/builtin-bundle.c index 4bd596a..521bbda 100644 --- a/builtin-bundle.c +++ b/builtin-bundle.c @@ -13,7 +13,7 @@ * bundle supporting git-fetch, git-pull, and git-ls-remote */ -static const char *bundle_usage="git-bundle (--create | --verify | --list-heads [refname]... | --unbundle [refname]... )"; +static const char *bundle_usage="git-bundle (create | verify | list-heads [refname]... | unbundle [refname]... )"; static const char bundle_signature[] = "# v2 git bundle\n"; @@ -39,7 +39,8 @@ static void add_to_ref_list(const unsigned char *sha1, const char *name, } struct bundle_header { - struct ref_list prerequisites, references; + struct ref_list prerequisites; + struct ref_list references; }; /* this function returns the length of the string */ @@ -47,7 +48,7 @@ static int read_string(int fd, char *buffer, int size) { int i; for (i = 0; i < size - 1; i++) { - int count = read(fd, buffer + i, 1); + int count = xread(fd, buffer + i, 1); if (count < 0) return error("Read error: %s", strerror(errno)); if (count == 0) { @@ -75,18 +76,25 @@ static int read_header(const char *path, struct bundle_header *header) { } while (read_string(fd, buffer, sizeof(buffer)) > 0 && buffer[0] != '\n') { - int offset = buffer[0] == '-' ? 1 : 0; + int is_prereq = buffer[0] == '-'; + int offset = is_prereq ? 1 : 0; int len = strlen(buffer); unsigned char sha1[20]; - struct ref_list *list = offset ? &header->prerequisites + struct ref_list *list = is_prereq ? &header->prerequisites : &header->references; - if (get_sha1_hex(buffer + offset, sha1)) { - close(fd); - return error("invalid SHA1: %s", buffer); - } + char delim; + if (buffer[len - 1] == '\n') buffer[len - 1] = '\0'; - add_to_ref_list(sha1, buffer + 41 + offset, list); + if (get_sha1_hex(buffer + offset, sha1)) { + warn("unrecognized header: %s", buffer); + continue; + } + delim = buffer[40 + offset]; + if (!isspace(delim) && (delim != '\0' || !is_prereq)) + die ("invalid header: %s", buffer); + add_to_ref_list(sha1, isspace(delim) ? + buffer + 41 + offset : "", list); } return fd; } @@ -127,20 +135,28 @@ static int fork_with_pipe(const char **argv, int *in, int *out) dup2(fdin[0], 0); close(fdin[0]); close(fdin[1]); - } else if (in) + } else if (in) { dup2(*in, 0); + close(*in); + } if (needs_out) { dup2(fdout[1], 1); close(fdout[0]); close(fdout[1]); - } else if (out) + } else if (out) { dup2(*out, 1); + close(*out); + } exit(execv_git_cmd(argv)); } if (needs_in) close(fdin[0]); + else if (in) + close(*in); if (needs_out) close(fdout[1]); + else if (out) + close(*out); return pid; } @@ -151,29 +167,28 @@ static int verify_bundle(struct bundle_header *header) * to be verbose about the errors */ struct ref_list *p = &header->prerequisites; - const char *argv[5] = {"rev-list", "--stdin", "--not", "--all", NULL}; - int pid, in, out, i, ret = 0; + char **argv; + int pid, out, i, ret = 0; char buffer[1024]; - in = out = -1; - pid = fork_with_pipe(argv, &in, &out); + argv = xmalloc((p->nr + 4) * sizeof(const char *)); + argv[0] = "rev-list"; + argv[1] = "--not"; + argv[2] = "--all"; + for (i = 0; i < p->nr; i++) + argv[i + 3] = xstrdup(sha1_to_hex(p->list[i].sha1)); + argv[p->nr + 3] = NULL; + out = -1; + pid = fork_with_pipe((const char **)argv, NULL, &out); if (pid < 0) return error("Could not fork rev-list"); - if (!fork()) { - for (i = 0; i < p->nr; i++) { - write(in, sha1_to_hex(p->list[i].sha1), 40); - write(in, "\n", 1); - } - close(in); - exit(0); - } - close(in); - while (read_string(out, buffer, sizeof(buffer)) > 0) { - if (ret++ == 0) - error ("The bundle requires the following commits you lack:"); - fprintf(stderr, "%s", buffer); - } + while (read_string(out, buffer, sizeof(buffer)) > 0) + ; /* do nothing */ close(out); + for (i = 0; i < p->nr; i++) + free(argv[i + 3]); + free(argv); + while (waitpid(pid, &i, 0) < 0) if (errno != EINTR) return -1; @@ -205,8 +220,8 @@ static int list_heads(struct bundle_header *header, int argc, const char **argv) static void show_commit(struct commit *commit) { - write(1, sha1_to_hex(commit->object.sha1), 40); - write(1, "\n", 1); + write_or_die(1, sha1_to_hex(commit->object.sha1), 40); + write_or_die(1, "\n", 1); if (commit->parents) { free_commit_list(commit->parents); commit->parents = NULL; @@ -216,15 +231,15 @@ static void show_commit(struct commit *commit) static void show_object(struct object_array_entry *p) { /* An object with name "foo\n0000000..." can be used to - * * confuse downstream git-pack-objects very badly. - * */ + * confuse downstream git-pack-objects very badly. + */ const char *ep = strchr(p->name, '\n'); int len = ep ? ep - p->name : strlen(p->name); - write(1, sha1_to_hex(p->item->sha1), 40); - write(1, " ", 1); + write_or_die(1, sha1_to_hex(p->item->sha1), 40); + write_or_die(1, " ", 1); if (len) - write(1, p->name, len); - write(1, "\n", 1); + write_or_die(1, p->name, len); + write_or_die(1, "\n", 1); } static int create_bundle(struct bundle_header *header, const char *path, @@ -243,7 +258,7 @@ static int create_bundle(struct bundle_header *header, const char *path, return error("Could not write to '%s'", path); /* write signature */ - write(bundle_fd, bundle_signature, strlen(bundle_signature)); + write_or_die(bundle_fd, bundle_signature, strlen(bundle_signature)); /* write prerequisites */ memcpy(argv_boundary + 2, argv + 1, argc * sizeof(const char *)); @@ -256,7 +271,7 @@ static int create_bundle(struct bundle_header *header, const char *path, return -1; while ((i = read_string(out, buffer, sizeof(buffer))) > 0) if (buffer[0] == '-') - write(bundle_fd, buffer, i); + write_or_die(bundle_fd, buffer, i); while ((i = waitpid(pid, &status, 0)) < 0) if (errno != EINTR) return error("rev-list died"); @@ -279,16 +294,16 @@ static int create_bundle(struct bundle_header *header, const char *path, char *ref; if (dwim_ref(e->name, strlen(e->name), sha1, &ref) != 1) continue; - write(bundle_fd, sha1_to_hex(e->item->sha1), 40); - write(bundle_fd, " ", 1); - write(bundle_fd, ref, strlen(ref)); - write(bundle_fd, "\n", 1); + write_or_die(bundle_fd, sha1_to_hex(e->item->sha1), 40); + write_or_die(bundle_fd, " ", 1); + write_or_die(bundle_fd, ref, strlen(ref)); + write_or_die(bundle_fd, "\n", 1); free(ref); } } /* end header */ - write(bundle_fd, "\n", 1); + write_or_die(bundle_fd, "\n", 1); /* write pack */ argv_pack[0] = "pack-objects"; @@ -301,7 +316,6 @@ static int create_bundle(struct bundle_header *header, const char *path, if (pid < 0) return error("Could not spawn pack-objects"); close(1); - close(bundle_fd); dup2(in, 1); close(in); prepare_revision_walk(&revs); @@ -327,7 +341,6 @@ static int unbundle(struct bundle_header *header, int bundle_fd, pid = fork_with_pipe(argv_index_pack, &bundle_fd, &dev_null); if (pid < 0) return error("Could not spawn index-pack"); - close(bundle_fd); while (waitpid(pid, &status, 0) < 0) if (errno != EINTR) return error("index-pack died"); diff --git a/index-pack.c b/index-pack.c index 24bbdcd..64d75f8 100644 --- a/index-pack.c +++ b/index-pack.c @@ -457,8 +457,9 @@ static void parse_pack_objects(unsigned char *sha1) /* If input_fd is a file, we should have reached its end now. */ if (fstat(input_fd, &st)) die("cannot fstat packfile: %s", strerror(errno)); - if (input_fd && S_ISREG(st.st_mode) && st.st_size != consumed_bytes) - die("pack has junk at the end: 0%o, %d, %d %d", st.st_mode, (int)st.st_size, (int)consumed_bytes, input_fd); + if (S_ISREG(st.st_mode) && + lseek(input_fd, 0, SEEK_CUR) - input_len != st.st_size) + die("pack has junk at the end"); if (!nr_deltas) return; -- cgit v0.10.2-6-g49f6 From fb9a54150d308345a7027baae528b8fe90bd41f7 Mon Sep 17 00:00:00 2001 From: Johannes Schindelin Date: Thu, 22 Feb 2007 21:25:41 +0100 Subject: git-bundle: avoid fork() in verify_bundle() We can use the revision walker easily for checking if the prerequisites are met, instead of fork()ing off a rev-list, which would list only the first unmet prerequisite. Signed-off-by: Johannes Schindelin Signed-off-by: Junio C Hamano diff --git a/builtin-bundle.c b/builtin-bundle.c index 521bbda..191ec55 100644 --- a/builtin-bundle.c +++ b/builtin-bundle.c @@ -19,7 +19,7 @@ static const char bundle_signature[] = "# v2 git bundle\n"; struct ref_list { unsigned int nr, alloc; - struct { + struct ref_list_entry { unsigned char sha1[20]; char *name; } *list; @@ -167,33 +167,54 @@ static int verify_bundle(struct bundle_header *header) * to be verbose about the errors */ struct ref_list *p = &header->prerequisites; - char **argv; - int pid, out, i, ret = 0; - char buffer[1024]; + struct rev_info revs; + const char *argv[] = {NULL, "--all"}; + struct object_array refs; + struct commit *commit; + int i, ret = 0, req_nr; + const char *message = "The bundle requires these lacking revs:"; - argv = xmalloc((p->nr + 4) * sizeof(const char *)); - argv[0] = "rev-list"; - argv[1] = "--not"; - argv[2] = "--all"; - for (i = 0; i < p->nr; i++) - argv[i + 3] = xstrdup(sha1_to_hex(p->list[i].sha1)); - argv[p->nr + 3] = NULL; - out = -1; - pid = fork_with_pipe((const char **)argv, NULL, &out); - if (pid < 0) - return error("Could not fork rev-list"); - while (read_string(out, buffer, sizeof(buffer)) > 0) - ; /* do nothing */ - close(out); - for (i = 0; i < p->nr; i++) - free(argv[i + 3]); - free(argv); - - while (waitpid(pid, &i, 0) < 0) - if (errno != EINTR) - return -1; - if (!ret && (!WIFEXITED(i) || WEXITSTATUS(i))) - return error("At least one prerequisite is lacking."); + init_revisions(&revs, NULL); + for (i = 0; i < p->nr; i++) { + struct ref_list_entry *e = p->list + i; + struct object *o = parse_object(e->sha1); + if (o) { + o->flags |= BOUNDARY_SHOW; + add_pending_object(&revs, o, e->name); + continue; + } + if (++ret == 1) + error(message); + error("%s %s", sha1_to_hex(e->sha1), e->name); + } + if (revs.pending.nr == 0) + return ret; + req_nr = revs.pending.nr; + setup_revisions(2, argv, &revs, NULL); + + memset(&refs, 0, sizeof(struct object_array)); + for (i = 0; i < revs.pending.nr; i++) { + struct object_array_entry *e = revs.pending.objects + i; + add_object_array(e->item, e->name, &refs); + } + + prepare_revision_walk(&revs); + + i = req_nr; + while (i && (commit = get_revision(&revs))) + if (commit->object.flags & BOUNDARY_SHOW) + i--; + + for (i = 0; i < req_nr; i++) + if (!(refs.objects[i].item->flags & SHOWN)) { + if (++ret == 1) + error(message); + error("%s %s", sha1_to_hex(refs.objects[i].item->sha1), + refs.objects[i].name); + } + + for (i = 0; i < refs.nr; i++) + clear_commit_marks((struct commit *)refs.objects[i].item, -1); return ret; } -- cgit v0.10.2-6-g49f6 From 3d1efd8f1ddc0de423426b5a2a8c6c0a30f1d46e Mon Sep 17 00:00:00 2001 From: Johannes Schindelin Date: Fri, 23 Feb 2007 02:56:31 +0100 Subject: git-bundle: fix 'create --all' diff --git a/revision.c b/revision.c index 15bdaf6..c1bf5ea 100644 --- a/revision.c +++ b/revision.c @@ -480,7 +480,7 @@ static int handle_one_ref(const char *path, const unsigned char *sha1, int flag, struct all_refs_cb *cb = cb_data; struct object *object = get_reference(cb->all_revs, path, sha1, cb->all_flags); - add_pending_object(cb->all_revs, object, ""); + add_pending_object(cb->all_revs, object, path); return 0; } -- cgit v0.10.2-6-g49f6 From 239296770dae75e21c179733785731ec6ffae1f5 Mon Sep 17 00:00:00 2001 From: Johannes Schindelin Date: Fri, 23 Feb 2007 03:17:51 +0100 Subject: git-bundle: record commit summary in the prerequisite data diff --git a/builtin-bundle.c b/builtin-bundle.c index 191ec55..d74afaa 100644 --- a/builtin-bundle.c +++ b/builtin-bundle.c @@ -267,7 +267,7 @@ static int create_bundle(struct bundle_header *header, const char *path, int argc, const char **argv) { int bundle_fd = -1; - const char **argv_boundary = xmalloc((argc + 3) * sizeof(const char *)); + const char **argv_boundary = xmalloc((argc + 4) * sizeof(const char *)); const char **argv_pack = xmalloc(4 * sizeof(const char *)); int pid, in, out, i, status; char buffer[1024]; @@ -282,10 +282,11 @@ static int create_bundle(struct bundle_header *header, const char *path, write_or_die(bundle_fd, bundle_signature, strlen(bundle_signature)); /* write prerequisites */ - memcpy(argv_boundary + 2, argv + 1, argc * sizeof(const char *)); + memcpy(argv_boundary + 3, argv + 1, argc * sizeof(const char *)); argv_boundary[0] = "rev-list"; argv_boundary[1] = "--boundary"; - argv_boundary[argc + 1] = NULL; + argv_boundary[2] = "--pretty=oneline"; + argv_boundary[argc + 2] = NULL; out = -1; pid = fork_with_pipe(argv_boundary, NULL, &out); if (pid < 0) -- cgit v0.10.2-6-g49f6 From 64d99e9c5a4a3fb35d803894992764a6e288de5d Mon Sep 17 00:00:00 2001 From: Junio C Hamano Date: Sat, 24 Feb 2007 01:16:58 -0800 Subject: bundle: reword missing prerequisite error message As suggested by Mark Levedahl. Signed-off-by: Junio C Hamano diff --git a/builtin-bundle.c b/builtin-bundle.c index d74afaa..d41a413 100644 --- a/builtin-bundle.c +++ b/builtin-bundle.c @@ -172,7 +172,7 @@ static int verify_bundle(struct bundle_header *header) struct object_array refs; struct commit *commit; int i, ret = 0, req_nr; - const char *message = "The bundle requires these lacking revs:"; + const char *message = "Repository lacks these prerequisite commits:"; init_revisions(&revs, NULL); for (i = 0; i < p->nr; i++) { -- cgit v0.10.2-6-g49f6