From 2e2aa8d9032ccdfdecaab51c60c5bada517f60bc Mon Sep 17 00:00:00 2001 From: Yang Zhao Date: Fri, 13 Dec 2019 15:52:45 -0800 Subject: git-p4: use dict.items() iteration for python3 compatibility Python3 uses dict.items() instead of .iteritems() to provide iteratoration over dict. Although items() is technically less efficient for python2.7 (allocates a new list instead of simply iterating), the amount of data involved is very small and the penalty negligible. Signed-off-by: Yang Zhao Reviewed-by: Ben Keene Signed-off-by: Junio C Hamano diff --git a/git-p4.py b/git-p4.py index 7deee1b..b7e31d4 100755 --- a/git-p4.py +++ b/git-p4.py @@ -1745,7 +1745,7 @@ class P4Submit(Command, P4UserMap): break if not change_entry: die('Failed to decode output of p4 change -o') - for key, value in change_entry.iteritems(): + for key, value in change_entry.items(): if key.startswith('File'): if 'depot-paths' in settings: if not [p for p in settings['depot-paths'] -- cgit v0.10.2-6-g49f6