From 16538bfd2c429a81a86011f32afa189047afd6e5 Mon Sep 17 00:00:00 2001 From: Miriam Rubio Date: Mon, 17 Feb 2020 09:40:28 +0100 Subject: bisect--helper: convert `vocab_*` char pointers to char arrays Instead of using a pointer that points at a constant string, just give name directly to the constant string; this way, we do not have to allocate a pointer variable in addition to the string we want to use. Let's convert `vocab_bad` and `vocab_good` char pointers to char arrays. Mentored-by: Christian Couder Signed-off-by: Miriam Rubio Signed-off-by: Junio C Hamano diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c index 1718df7..36c09b7 100644 --- a/builtin/bisect--helper.c +++ b/builtin/bisect--helper.c @@ -52,8 +52,8 @@ static void set_terms(struct bisect_terms *terms, const char *bad, terms->term_bad = xstrdup(bad); } -static const char *vocab_bad = "bad|new"; -static const char *vocab_good = "good|old"; +static const char vocab_bad[] = "bad|new"; +static const char vocab_good[] = "good|old"; /* * Check whether the string `term` belongs to the set of strings -- cgit v0.10.2-6-g49f6