From 92a5d1c9b446839a748a465518e5926451b63460 Mon Sep 17 00:00:00 2001 From: Junio C Hamano Date: Tue, 7 Sep 2021 15:10:22 -0700 Subject: hash-object: prefix_filename() returns allocated memory these days Back when a1be47e4 (hash-object: fix buffer reuse with --path in a subdirectory, 2017-03-20) was written, the prefix_filename() helper used a static piece of memory to the caller, making the caller responsible for copying it, if it wants to keep it across another call to the same function. Two callers of the prefix_filename() in hash-object were made to xstrdup() the value obtained from it. But in the same series, when e4da43b1 (prefix_filename: return newly allocated string, 2017-03-20) changed the rule to gave the caller possession of the memory, we forgot to revert one of the xstrdup() changes, allowing the returned value to leak. Signed-off-by: Junio C Hamano diff --git a/builtin/hash-object.c b/builtin/hash-object.c index 640ef4d..084cba2 100644 --- a/builtin/hash-object.c +++ b/builtin/hash-object.c @@ -117,7 +117,7 @@ int cmd_hash_object(int argc, const char **argv, const char *prefix) prefix = setup_git_directory_gently(&nongit); if (vpath && prefix) - vpath = xstrdup(prefix_filename(prefix, vpath)); + vpath = prefix_filename(prefix, vpath); git_config(git_default_config, NULL); -- cgit v0.10.2-6-g49f6