From 70a0cc9e5c62f7b8ce0acc693e10a9e080f187ef Mon Sep 17 00:00:00 2001 From: Stefan Beller Date: Sun, 14 Jul 2013 23:35:47 +0200 Subject: commit: Fix a memory leak in determine_author_info The date variable is assigned new memory via xmemdupz and 2 lines later it is assigned new memory again via xmalloc, but the first assignment is never freed nor used. Signed-off-by: Stefan Beller Reviewed-by: Jonathan Nieder Signed-off-by: Junio C Hamano diff --git a/builtin/commit.c b/builtin/commit.c index d21d07a..0575ad8 100644 --- a/builtin/commit.c +++ b/builtin/commit.c @@ -526,7 +526,6 @@ static void determine_author_info(struct strbuf *author_ident) (lb - strlen(" ") - (a + strlen("\nauthor ")))); email = xmemdupz(lb + strlen("<"), rb - (lb + strlen("<"))); - date = xmemdupz(rb + strlen("> "), eol - (rb + strlen("> "))); len = eol - (rb + strlen("> ")); date = xmalloc(len + 2); *date = '@'; -- cgit v0.10.2-6-g49f6