From d51428bf17e9f17071836350299e256cac2d503a Mon Sep 17 00:00:00 2001 From: Jeff King Date: Thu, 24 Jul 2014 00:40:43 -0400 Subject: receive-pack: don't copy "dir" parameter We used to do this so could pass a mutable string to enter_repo. But since 1c64b48 (enter_repo: do not modify input, 2011-10-04), this is not necessary. The resulting code is simpler, and it fixes a minor leak. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano diff --git a/builtin/receive-pack.c b/builtin/receive-pack.c index c323081..be8c2db 100644 --- a/builtin/receive-pack.c +++ b/builtin/receive-pack.c @@ -1125,7 +1125,7 @@ int cmd_receive_pack(int argc, const char **argv, const char *prefix) int advertise_refs = 0; int stateless_rpc = 0; int i; - char *dir = NULL; + const char *dir = NULL; struct command *commands; struct sha1_array shallow = SHA1_ARRAY_INIT; struct sha1_array ref = SHA1_ARRAY_INIT; @@ -1160,7 +1160,7 @@ int cmd_receive_pack(int argc, const char **argv, const char *prefix) } if (dir) usage(receive_pack_usage); - dir = xstrdup(arg); + dir = arg; } if (!dir) usage(receive_pack_usage); -- cgit v0.10.2-6-g49f6