From 0210231b0803f881bf765bb2d7284c119c6ce9b6 Mon Sep 17 00:00:00 2001 From: Johannes Schindelin Date: Sat, 21 Apr 2018 13:14:28 +0200 Subject: git_setup_gettext: plug memory leak The system_path() function returns a freshly-allocated string. We need to release it. Signed-off-by: Johannes Schindelin Signed-off-by: Junio C Hamano diff --git a/gettext.c b/gettext.c index 3eb20c5..4f59dfa 100644 --- a/gettext.c +++ b/gettext.c @@ -159,18 +159,23 @@ static void init_gettext_charset(const char *domain) void git_setup_gettext(void) { const char *podir = getenv(GIT_TEXT_DOMAIN_DIR_ENVIRONMENT); + char *p = NULL; if (!podir) - podir = system_path(GIT_LOCALE_PATH); + podir = p = system_path(GIT_LOCALE_PATH); - if (!is_directory(podir)) + if (!is_directory(podir)) { + free(p); return; + } bindtextdomain("git", podir); setlocale(LC_MESSAGES, ""); setlocale(LC_TIME, ""); init_gettext_charset("git"); textdomain("git"); + + free(p); } /* return the number of columns of string 's' in current locale */ -- cgit v0.10.2-6-g49f6