From 6163f3f1a4288a6a17d2e3cdee4391b25ef09edd Mon Sep 17 00:00:00 2001 From: Thomas Gummerer Date: Fri, 12 Oct 2018 19:40:37 +0100 Subject: config.mak.dev: add -Wall, primarily for -Wformat, to help autoconf users 801fa63a90 ("config.mak.dev: add -Wformat-security", 2018-09-08) added the "-Wformat-security" to the flags set in config.mak.dev. In the gcc man page this is documented as: If -Wformat is specified, also warn about uses of format functions that represent possible security problems. [...] The commit did however not add the "-Wformat" flag, but instead relied on the fact that "-Wall" is set in the Makefile by default and that "-Wformat" is part of "-Wall". Unfortunately, those who use config.mak.autogen generated with the autoconf to configure toolchain do *not* get "-Wall" in their CFLAGS and the added -Wformat-security had no effect. Worse yet, newer versions of gcc (gcc 8.2.1 in this particular case) warn about the lack of "-Wformat" and thus compilation fails only with this option set. We could fix it by adding "-Wformat", but in general we do want all checks included in "-Wall", so let's add it to config.mak.dev to cover more cases. Signed-off-by: Thomas Gummerer Helped-by: Jeff King Helped-by: Jonathan Nieder Signed-off-by: Junio C Hamano diff --git a/config.mak.dev b/config.mak.dev index bfbd3df..74337f1 100644 --- a/config.mak.dev +++ b/config.mak.dev @@ -1,6 +1,7 @@ ifeq ($(filter no-error,$(DEVOPTS)),) CFLAGS += -Werror endif +CFLAGS += -Wall CFLAGS += -Wdeclaration-after-statement CFLAGS += -Wformat-security CFLAGS += -Wno-format-zero-length -- cgit v0.10.2-6-g49f6