From 6a907786af835ac15962be53f1492f23e044f479 Mon Sep 17 00:00:00 2001 From: Stefan Beller Date: Tue, 23 Jul 2013 15:16:04 +0200 Subject: open_istream: remove unneeded check for null pointer 'st' is allocated via xmalloc a few lines before and passed to the stream opening functions. The xmalloc function is written in a way that either 'st' is allocated valid memory or xmalloc already dies. The function calls to open_istream_* do not change 'st', as the pointer is passed by reference and not a pointer of a pointer. Hence 'st' cannot be null at that part of the code. Signed-off-by: Stefan Beller Signed-off-by: Junio C Hamano diff --git a/streaming.c b/streaming.c index cac282f..efbc3ba 100644 --- a/streaming.c +++ b/streaming.c @@ -149,7 +149,7 @@ struct git_istream *open_istream(const unsigned char *sha1, return NULL; } } - if (st && filter) { + if (filter) { /* Add "&& !is_null_stream_filter(filter)" for performance */ struct git_istream *nst = attach_stream_filter(st, filter); if (!nst) -- cgit v0.10.2-6-g49f6