From 4d35f744219335d8b32df363891b6336dcf02a6e Mon Sep 17 00:00:00 2001 From: Moritz Baumann Date: Wed, 20 Jul 2022 18:17:45 +0000 Subject: git-p4: fix CR LF handling for utf16 files Perforce silently replaces LF with CR LF for "utf16" files if the client is a native Windows client. Since git's autocrlf logic does not undo this transformation for UTF-16 encoded files, git-p4 replaces CR LF with LF during the sync if the file type "utf16" is detected and the Perforce client platform indicates that this conversion is performed. Windows only runs on little-endian architectures, therefore the encoding of the byte stream received from the Perforce client is UTF-16-LE and the relevant byte sequence is 0D 00 0A 00. Signed-off-by: Moritz Baumann Signed-off-by: Junio C Hamano diff --git a/git-p4.py b/git-p4.py index 8fbf6eb..0a9d7e2 100755 --- a/git-p4.py +++ b/git-p4.py @@ -3148,7 +3148,7 @@ class P4Sync(Command, P4UserMap): raise e else: if p4_version_string().find('/NT') >= 0: - text = text.replace(b'\r\n', b'\n') + text = text.replace(b'\x0d\x00\x0a\x00', b'\x0a\x00') contents = [text] if type_base == "apple": -- cgit v0.10.2-6-g49f6