From 08337a97a2756cd89ab611444f37d67250d3c05b Mon Sep 17 00:00:00 2001 From: Sam Ravnborg Date: Tue, 27 Dec 2005 09:19:05 +0100 Subject: copy_fd: close ifd on error In copy_fd when write fails we ought to close input file descriptor. Signed-off-by: Sam Ravnborg Signed-off-by: Junio C Hamano diff --git a/copy.c b/copy.c index 7100eed..08a3d38 100644 --- a/copy.c +++ b/copy.c @@ -22,11 +22,14 @@ int copy_fd(int ifd, int ofd) buf += written; len -= written; } - else if (!written) + else if (!written) { + close(ifd); return error("copy-fd: write returned 0"); - else + } else { + close(ifd); return error("copy-fd: write returned %s", strerror(errno)); + } } } close(ifd); -- cgit v0.10.2-6-g49f6 From 8eafa3da62297eb91741321281fd3fb2a4236e97 Mon Sep 17 00:00:00 2001 From: Junio C Hamano Date: Tue, 27 Dec 2005 10:51:23 -0800 Subject: Guard a test against wc that pads its output with whitespace Spotted by Johannes. Signed-off-by: Junio C Hamano diff --git a/t/t5300-pack-object.sh b/t/t5300-pack-object.sh index 1510ea9..de45ac4 100755 --- a/t/t5300-pack-object.sh +++ b/t/t5300-pack-object.sh @@ -168,7 +168,7 @@ test_expect_success \ : sum of the index file itself && l=`wc -c Date: Tue, 27 Dec 2005 11:06:43 -0800 Subject: Fix bogus tests on rev-list output. These tests seem to mean checking the output with expected result, but was not doing its handrolled test helper function. Also fix the guard to workaround wc output that have whitespace padding, which was broken but not exposed because the test was not testing it ;-). Signed-off-by: Junio C Hamano diff --git a/t/t6001-rev-list-merge-order.sh b/t/t6001-rev-list-merge-order.sh index 8ec9ebb..368b8d9 100755 --- a/t/t6001-rev-list-merge-order.sh +++ b/t/t6001-rev-list-merge-order.sh @@ -110,7 +110,7 @@ save_tag g4 unique_commit g6 tree -p g3 -p h2 git-update-ref HEAD $(tag l5) -test_expect_success 'rev-list has correct number of entries' 'git-rev-list HEAD | wc -l | tr -s " "' < Date: Tue, 27 Dec 2005 11:52:51 -0800 Subject: Do not mark tags fetched via --tags flag as mergeable Otherwise "git pull --tags" would mistakenly try to merge all of them, which is never what the user wants. Signed-off-by: Junio C Hamano diff --git a/git-fetch.sh b/git-fetch.sh index 767ca61..125bcea 100755 --- a/git-fetch.sh +++ b/git-fetch.sh @@ -192,7 +192,7 @@ then sed -e ' /\^/d s/^[^ ]* // - s/.*/&:&/') + s/.*/.&:&/') if test "$#" -gt 1 then # remote URL plus explicit refspecs; we need to merge them. -- cgit v0.10.2-6-g49f6