path: root/t/
AgeCommit message (Collapse)Author
2020-04-22Merge branch 'jk/t3419-drop-expensive-tests'Junio C Hamano
Test update. * jk/t3419-drop-expensive-tests: t3419: drop EXPENSIVE tests
2020-03-22t3419: drop EXPENSIVE testsJeff King
When t3419 was originally written, it was designed to run a smaller test for correctness, and then the same test with a larger number of patches for performance. But it seems unlikely the latter was helping us: - it was marked with EXPENSIVE, so hardly anybody ran it anyway - there's no indication that it was more likely to find bugs than the smaller case (the commit message isn't very helpful, but the original cover letter describes it as: "The first patch adds correctness and (optional) performance tests". - the timing results are shown only via test_debug(). So also not run unless the user says "-d", and then not provided in any machine-readable form. If we're interested in performance regressions, a script in t/perf would be more appropriate. I didn't add one here, because it's not at all clear to me that what the script is timing is even all that interesting. Let's simplify the script by dropping the EXPENSIVE run. That in turn lets us drop the do_tests() wrapper, which lets us consistently use single-quotes for our test snippets. And we can drop the useless test_debug() timings, as well as their run() helper. And finally, while we're here, we can replace the count() helper with the standard test_seq(). Signed-off-by: Jeff King <> Signed-off-by: Junio C Hamano <>
2020-03-21Merge branch 'en/rebase-backend'Junio C Hamano
Test fix. * en/rebase-backend: t3419: prevent failure when run with EXPENSIVE
2020-03-20t3419: prevent failure when run with EXPENSIVEbrian m. carlson
This test runs a function which itself runs several assertions. The last of these assertions cleans up the .git/rebase-apply directory, since when run with EXPENSIVE set, the function is invoked a second time to run the same tests with a larger data set. However, as of 2ac0d6273f ("rebase: change the default backend from "am" to "merge"", 2020-02-15), the default backend of rebase has changed, and cleaning up the rebase-apply directory has no effect: it no longer exists, since we're using rebase-merge instead. Since we don't really care which rebase backend is in use, let's just use the command "git rebase --quit", which will do the right thing regardless. Signed-off-by: brian m. carlson <> Signed-off-by: Junio C Hamano <>
2020-01-27t3419: stop losing return code of git commandDenton Liu
Fix invocation of git command so its exit codes is not lost within a non-assignment command substitution. Signed-off-by: Denton Liu <> Signed-off-by: Junio C Hamano <>
2016-05-13t9100,t3419: enclose all test code in single-quotesJeff King
A few tests here use double-quotes around the snippets of shell code to run the tests. None of these tests wants to do any interpolation at all, and it just leads to an extra layer of quoting around all double-quotes and dollar signs inside the snippet. Let's switch to single quotes, like most other test scripts. Signed-off-by: Jeff King <> Signed-off-by: Junio C Hamano <>
2014-06-13tests: drop GIT_*_TIMING_TESTS environment variable supportJunio C Hamano
Two tests (t3302 and t3419) used to have their own environment variable to trigger expensive tests without enabling expensive tests in other scripts; a user could set GIT_NOTES_TIMING_TESTS but not GIT_TEST_LONG and run the whole test suite and trigger expensive tests only in t3302 but not other tests. The same for GIT_PATCHID_TIMING_TESTS in t3419. While this may have seemed a good flexibility, in reality if you are concentrating on a single test (e.g. t3302), you can just run that single test with the GIT_TEST_LONG to trigger expensive tests. It does not seem worth forcing other people who may want to come up with their own expensive tests to invent new environment variables by keeping this convention. Drop them. Signed-off-by: Junio C Hamano <>
2014-06-09t3419: drop unnecessary NOT_EXPENSIVE pseudo-prerequisiteJunio C Hamano
This was only necessary because do_tests helper the script defines took its parameters in a wrong order. Just pass an empty string (or not passing the optional EXPENSIVE prerequisite) when running the test with a light-weight set of parameters and have the shell do the right thing when parsing test_expect_success helper. Also update coding style while we are at it. Signed-off-by: Junio C Hamano <>
2014-06-09test: turn USR_BIN_TIME into a lazy prerequisiteJunio C Hamano
Two test scripts (t3302 and t3419) had copy & paste code to set USR_BIN_TIME prerequisite. Use the test_lazy_prereq helper to define them in the common t/ Signed-off-by: Junio C Hamano <>
2011-12-09test: fix '&&' chainingRamkumar Ramachandra
Breaks in a test assertion's && chain can potentially hide failures from earlier commands in the chain by adding " &&" at the end of line to the commands that need them. Signed-off-by: Ramkumar Ramachandra <> Acked-by: Jonathan Nieder <> Signed-off-by: Junio C Hamano <>
2010-12-21t3419-*.sh: Fix arithmetic expansion syntax errorRamsay Jones
Some shells, for example dash versions older than 0.5.4, need to spell a variable reference as '$N' rather than 'N' in an arithmetic expansion. In order to avoid the syntax error, we change the offending variable reference from 'i' to '$i' in function scramble. There is nothing bash specific to this test script (and we shouldn't have any bash dependent test). Fix its shebang line. Signed-off-by: Ramsay Jones <> Signed-off-by: Junio C Hamano <>
2010-09-24add rebase patch id testsClemens Buchacher
Signed-off-by: Clemens Buchacher <> Signed-off-by: Junio C Hamano <>