path: root/perl
AgeCommit message (Collapse)Author do not break inheritanceChristian Jaeger
Make it possible to write subclasses of Signed-off-by: Christian Jaeger <> Signed-off-by: Junio C Hamano <> Use File::Temp->tempfile instead of ->newMarcus Griep
Perl 5.8.0 ships with File::Temp 0.13, which does not have the new() interface introduced in 0.14, as pointed out by Tom G. Christensen. This modifies to use the more established tempfile() interface and updates 'git svn' to match. Signed-off-by: Marcus Griep <> Acked-by: Eric Wong <> Tested-by: Tom G. Christensen <> Signed-off-by: Junio C Hamano <> Make File::Spec and File::Temp requirement lazyMarcus Griep
This will ensure that the API at large is accessible to nearly all Perl versions, while only the temp file caching API is tied to the File::Temp and File::Spec modules being available. Signed-off-by: Marcus Griep <> Signed-off-by: Junio C Hamano <> Add faculties to allow temp files to be cachedMarcus Griep
This patch offers a generic interface to allow temp files to be cached while using an instance of the 'Git' package. If many temp files are created and destroyed during the execution of a program, this caching mechanism can help reduce the amount of files created and destroyed by the filesystem. The temp_acquire method provides a weak guarantee that a temp file will not be stolen by subsequent requests. If a file is locked when another acquire request is made, a simple error is thrown. Signed-off-by: Marcus Griep <> Acked-by: Eric Wong <>
2008-08-06perl/Makefile: handle paths with spaces in the NO_PERL_MAKEMAKER sectionBrandon Casey
Use double quotes to protect against paths which may contain spaces. Signed-off-by: Brandon Casey <> Signed-off-by: Junio C Hamano <>
2008-08-05Fix typo in perl/Git.pmAbhijit Menon-Sen
Signed-off-by: Abhijit Menon-Sen <> Signed-off-by: Junio C Hamano <>
2008-08-05Fix hash slice syntax errorAbhijit Menon-Sen
Signed-off-by: Abhijit Menon-Sen <> Signed-off-by: Junio C Hamano <> localise $? in command_close_bidi_pipe()Abhijit Menon-Sen
Git::DESTROY calls _close_cat_blob and _close_hash_and_insert_object, which in turn call command_close_bidi_pipe, which calls waitpid, which alters $?. If this happens during global destruction, it may alter the program's exit status unexpectedly. Making $? local to the function solves the problem. (The problem was discovered due to a failure of test #8 in Signed-off-by: Abhijit Menon-Sen <> Signed-off-by: Junio C Hamano <>
2008-07-30Replace uses of "git-var" with "git var"Todd Zullinger
Signed-off-by: Todd Zullinger <> Signed-off-by: Junio C Hamano <>
2008-07-25perl/Makefile: update NO_PERL_MAKEMAKER sectionBrandon Casey
The perl modules must be copied to blib/lib so they are available for testing. Signed-off-by: Brandon Casey <> Signed-off-by: Junio C Hamano <> Add remote_refs() git-ls-remote frontendPetr Baudis
This patch also converts the good ole' git-remote.perl to use it. It is otherwise used in the machinery and I guess other scripts might find it useful too. Unfortunately, git-ls-remote --heads . is subtly different from git-ls-remote . refs/heads/ (since the second matches anywhere in the string, not just at the beginning) so we have to provide interface for both. Signed-off-by: Petr Baudis <> Signed-off-by: Junio C Hamano <> fix return value of config methodLea Wiemann
If config is called in array context, it is supposed to return all values set for the given option key. This works for all cases except if there is no value set at all. In that case, it wrongly returns (undef) instead of (). This fixes the return statement so that it returns undef in scalar context but an empty array in array context. Signed-off-by: Lea Wiemann <> Signed-off-by: Junio C Hamano <> fix documentation of hash_objectLea Wiemann
The documentation of hash_object incorrectly states that it accepts a file handle -- in fact it doesn't, and there is even a TODO comment for this. This fixes the documentation. Signed-off-by: Lea Wiemann <> Signed-off-by: Junio C Hamano <>
2008-05-28Git::cat_blob: allow using an empty blob to fix git-svn breakageJunio C Hamano
Recent "git-svn optimization" series introduced Git::cat_blob() subroutine whose interface was broken in that it returned the size of the blob but signalled an error by returning 0. You can never use an empty blob with such an interface. This fixes the interface to return a negative value to signal an error. Reported by Björn Steinbrink. Signed-off-by: Junio C Hamano <> Add hash_and_insert_object and cat_blobAdam Roben
These functions are more efficient ways of executing `git hash-object -w` and `git cat-file blob` when you are dealing with many files/objects. Signed-off-by: Adam Roben <> Signed-off-by: Junio C Hamano <> Add command_bidi_pipe and command_close_bidi_pipeAdam Roben
command_bidi_pipe hands back the stdin and stdout file handles from the executed command. command_close_bidi_pipe closes these handles and terminates the process. Signed-off-by: Adam Roben <> Signed-off-by: Junio C Hamano <> Don't require repository instance for identFrank Lichtenheld
git var doesn't require to be called in a repository anymore, so don't require it either. Signed-off-by: Frank Lichtenheld <> Signed-off-by: Junio C Hamano <> Don't require a repository instance for configFrank Lichtenheld
git config itself doesn't require to be called in a repository, so don't add arbitrary restrictions. Signed-off-by: Frank Lichtenheld <> Signed-off-by: Junio C Hamano <>
2007-12-11Don't cache DESTDIR in perl/perl.mak.Gerrit Pape
DESTDIR is supposed to be overridden on 'make install' after doing 'make'. Have the automatically generated perl/perl.mak not cache the value of DESTDIR to support that for the perl/ subdirectory also. Signed-off-by: Gerrit Pape <> Signed-off-by: Junio C Hamano <>
2007-12-06Color support for "git-add -i"Junio C Hamano
This is mostly lifted from earlier series by Dan Zwell, but updated to use "git config --get-color" and "git config --get-colorbool" to make it simpler and more consistent with commands written in C. A new configuration color.interactive variable is like color.diff and color.status, and controls if "git-add -i" uses color. A set of configuration variables, color.interactive.<slot>, are used to define what color is used for the prompt, header, and help text. For perl scripts, provides $repo->get_color() method, which takes the slot name and the default color, and returns the terminal escape sequence to color the output text. $repo->get_colorbool() method can be used to check if color is set to be used for a given operation. Signed-off-by: Junio C Hamano <>
2007-11-30Add config_int() method to the Git perl moduleJakub Narebski
Integer variables can have optional 'k', 'm' or 'g' suffix. config_int() method will return simple decimal number, taking care of those suffixes. Signed-off-by: Jakub Narebski <> Signed-off-by: Junio C Hamano <>
2007-11-07When exec() fails include the failing command in the error messageAsk Bjørn Hansen
git-svn occasionally fails with no details as to what went wrong - this should help debug those situations. Signed-off-by: Ask Bjørn Hansen <> Signed-off-by: Junio C Hamano <>
2007-08-23Install man3 manpages to $PREFIX/share/man/man3 even for site installsmartin f. krafft
MakeMaker supports three installation modes: perl, site, and vendor. The first and third install manpages to $PREFIX/share/man, only site installs to $PREFIX/man. For consistency with the rest of git, which does not make the distinction and writes all manpages to $PREFIX/share/man, this change makes sure that perl does too, even when it's installed in site mode. Signed-off-by: martin f. krafft <> Signed-off-by: Junio C Hamano <>
2007-08-22Fix git-remote for ActiveState PerlAlex Riesen
For reason unknown a package in ActiveState Perl 5.8.7 must implement READLINE method differently for scalar and array context. The code tested to work for more sane and recent version of perl (5.8.8 shipped with Ubuntu), so maybe it was always a requirement. Signed-off-by: Alex Riesen <> Signed-off-by: Junio C Hamano <>
2007-06-07War on whitespaceJunio C Hamano
This uses "git-apply --whitespace=strip" to fix whitespace errors that have crept in to our source files over time. There are a few files that need to have trailing whitespaces (most notably, test vectors). The results still passes the test, and build result in Documentation/ area is unchanged. Signed-off-by: Junio C Hamano <> config_boolean() -> config_bool()Petr Baudis
This patch renames config_boolean() to config_bool() for consistency with the commandline interface and because it is shorter but still obvious. ;-) It also changes the return value from some obscure string to real Perl boolean, allowing for clean user code. Signed-off-by: Petr Baudis <>
2007-05-04Allow PERL_PATH="/usr/bin/env perl"Bryan Larsen
There is a mechanism PERL_PATH in the Makefile to specify path to Perl binary, but sometimes it is convenient to let 'env' figure out where Perl comes from, with PERL_PATH="/usr/bin/env perl". Allowing this would make things easier to MacPorts, where we wish to work with the MacPorts perl if it is installed, but fall back to the system perl if it isn't. Signed-off-by: Bryan Larsen <> Signed-off-by: Junio C Hamano <>
2007-04-21perl: install private if the site version is older than our ownEric Wong
bdash (on IRC) had a problem with (via git-svn) when his site installation of was older than the version we package. Signed-off-by: Eric Wong <> Signed-off-by: Junio C Hamano <>
2007-03-14Do not output "GEN " when generating perl.makJohannes Schindelin
This fixes the same issue as 8bef6204, which became an issue again after 31d0399c. Besides, it is not really helpful to print just "GEN " (_without_ "perl.mak"). Signed-off-by: Johannes Schindelin <> Signed-off-by: Junio C Hamano <>
2007-03-07More build output cleaning upAlex Riesen
- print output file name for .c files - suppress output of the names of subdirectories when make changes into them - use GEN prefix for makefile generation in perl/ Signed-off-by: Alex Riesen <> Signed-off-by: Junio C Hamano <>
2007-03-06Make 'make' quiet by defaultShawn O. Pearce
Per Junio's suggestion we are setting 'make' to be quiet by default, with `make V=1` available to force GNU make back to its default behavior of showing each command it is running. Signed-off-by: Shawn O. Pearce <> Signed-off-by: Junio C Hamano <>
2007-03-06Make 'make' quieter while building gitShawn O. Pearce
I find it difficult to see compiler warnings amongst the massive spewing produced by GNU make as it works through our productions. This is especially true if CFLAGS winds up being rather long, due to a large number of -W options being enabled and due to a number of -D options being configured/required by my platform. By defining QUIET_MAKE (e.g. make QUIET_MAKE=YesPlease) during compilation users will get a less verbose output, such as: ... CC builtin-grep.c builtin-grep.c:187: warning: 'external_grep' defined but not used CC builtin-init-db.c CC builtin-log.c CC builtin-ls-files.c CC builtin-ls-tree.c ... The verbose (normal make) output is still the default. Signed-off-by: Shawn O. Pearce <> Signed-off-by: Junio C Hamano <>
2007-02-21Add config_boolean() method to the Git perl moduleTheodore Ts'o
Signed-off-by: "Theodore Ts'o" <> Signed-off-by: Junio C Hamano <>
2007-02-04Assorted typo fixesPavel Roskin
Signed-off-by: Junio C Hamano <>
2007-01-29[PATCH] Rename git-repo-config to git-config.Tom Prince
Signed-off-by: Tom Prince <> Signed-off-by: Junio C Hamano <>
2007-01-22Cleanup uninitialized value in chompAlex Riesen
which happens if you use ActiveState Perl and a pipe workaround specially for it. Signed-off-by: Alex Riesen <> Signed-off-by: Junio C Hamano <>
2007-01-22Force Activestate Perl to tie git command pipe handle to a handle classAlex Riesen
Otherwise it tries to tie it to a scalar and complains about missing method. Dunno why, may be ActiveState brokenness again. Signed-off-by: Alex Riesen <> Acked-by: Petr Baudis <> Signed-off-by: Junio C Hamano <>
2007-01-22Insert ACTIVESTATE_STRING in Git.pmAlex Riesen
Also add "git" to the pipe parameters, otherwise it does not work at all, as no git commands are usable out of git context. Signed-off-by: Alex Riesen <> Signed-off-by: Junio C Hamano <>
2007-01-16Fix spurious compile errorJohannes Schindelin
From time to time, I would get this error: [...] sed: -e expression #8, char 41: Unterminated `s' command make: *** [git-add--interactive] Error 1 Turns out that the function WriteMakefile() called in Makefile.PL outputs the message "Writing perl.mak for Git" to stdout! Thus, the output of "make -C perl -s --no-print-directory instlibdir" would be prefixed by that message whenever Makefile.PL was newer than perl.mak. This is fixed by redirecting stdout to stderr in Makefile.PL. Signed-off-by: Johannes E. Schindelin <> Signed-off-by: Junio C Hamano <>
2007-01-12use 'init' instead of 'init-db' for shipped docs and toolsNicolas Pitre
While 'init-db' still is and probably will always remain a valid git command for obvious backward compatibility reasons, it would be a good idea to move shipped tools and docs to using 'init' instead. Signed-off-by: Nicolas Pitre <> Signed-off-by: Junio C Hamano <>
2006-12-08Fix perl/ build.Junio C Hamano
An earlier commit f848718a broke the build in perl/ directory by allowing the Makefile.PL to overwrite the now-tracked Makefile. Fix this by forcing Makefile.PL to produce its output in perl.mak as the broken commit originally intended. Signed-off-by: Junio C Hamano <>
2006-12-04Make perl/ build procedure ActiveState friendly.Alex Riesen
On Cygwin + ActivateState Perl, Makefile generated with MakeMaker is not usable because of line-endings and back-slashes. This teaches perl/Makefile to write a handcrafted equivalent perl.mak file with 'make NO_PERL_MAKEMAKER=NoThanks'. Signed-off-by: Alex Riesen <> Signed-off-by: Junio C Hamano <> Kill Git.xs for nowPetr Baudis
This patch removes Git.xs from the repository for the time being. This should hopefully enable to finally make its way to master. Git.xs is not going away forever. When the Git libification makes some progress, it will hopefully return (but most likely as an optional component, due to the portability woes) since the performance boosts are really important for applications like Gitweb or Cogito. It needs to go away now since it is not really reliable in case you use it for several repositories in the scope of a single process, and that is not possible to fix without some either very ugly or very intrusive core changes. Rest in peace. (While you can.) Signed-off-by: Petr Baudis <> Signed-off-by: Junio C Hamano <>
2006-09-03Revert "Make it possible to set up libgit directly (instead of from the ↵Junio C Hamano
environment)" This reverts commit 0270083ded143fd49841e3d3d0cac5eb06081d2a.
2006-09-03Revert " Introduce fast get_object() method"Junio C Hamano
This reverts commit 3c479c37f8651d09e1d08b8d6ea9757164ee1235.
2006-08-13pass DESTDIR to the generated perl/MakefileEric Wong
Makes life for binary packagers easier, as the Perl modules will be installed inside DESTDIR. Signed-off-by: Eric Wong <> Signed-off-by: Junio C Hamano <>
2006-07-26Eliminate Scalar::Util usage from private-Error.pmPetr Baudis
We used just the blessed() routine so steal it from Scalar/ Unfortunately, Scalar::Util is not bundled with older Perl versions. This is a newer much saner blessed() version by Randal L. Schwarz. Signed-off-by: Petr Baudis <> Signed-off-by: Junio C Hamano <> Introduce fast get_object() methodPetr Baudis
Direct .xs routine. Note that it does not work 100% correctly when you juggle multiple repository objects, but it is not that bad either. The trouble is that we might reuse packs information for another Git project; that is not an issue since Git depends on uniqueness of SHA1 ids so if we have found the object somewhere else, it is nevertheless going to be the same object. It merely makes object existence detection through this method unreliable; it is duly noted in the documentation. At least that's how I see it, I hope I didn't overlook any other potential problem. I tested it for memory leaks and it appears to be doing ok. Signed-off-by: Petr Baudis <> Signed-off-by: Junio C Hamano <>
2006-07-09Make it possible to set up libgit directly (instead of from the environment)Petr Baudis
This introduces a setup_git() function which is essentialy a (public) backend for setup_git_env() which lets anyone specify custom sources for the various paths instead of environment variables. Since the repositories may get switched on the fly, this also updates code that caches paths to invalidate them properly; I hope neither of those is a sweet spot. It is used by Git.xs' xs__call_gate() to set up per-repository data for libgit's consumption. No code actually takes advantage of it yet but get_object() will in the next patches. Signed-off-by: Petr Baudis <> Signed-off-by: Junio C Hamano <> Introduce ident() and ident_person() methodsPetr Baudis
These methods can retrieve/parse the author/committer ident. Signed-off-by: Petr Baudis <> Signed-off-by: Junio C Hamano <>