path: root/perl/
AgeCommit message (Collapse)Author
2011-02-14perl: command_bidi_pipe() method should set-up git environmensMasatake Osanai
When command_input_pipe and command_output_pipe are used as a method of a Git::repository instance, they eventually call into _cmd_exec method that sets up the execution environment such as GIT_DIR, GIT_WORK_TREE environment variables and the current working directory in the child process that interacts with the repository. command_bidi_pipe however didn't expect to be called as such, and lacked all these set-up. Because of this, a program that did this did not work as expected: my $repo = Git->repository(Directory => '/some/where/else'); my ($pid, $in, $out, $ctx) = $repo->command_bidi_pipe(qw(hash-object -w --stdin-paths)); This patch refactors the _cmd_exec into _setup_git_cmd_env that sets up the execution environment, and makes _cmd_exec and command_bidi_pipe to use it. Note that unlike _cmd_exec that execv's a git command as an external process, command_bidi_pipe is called from the main line of control, and the execution environment needs to be restored after open2() does its magic. Signed-off-by: Masatake Osanai <> Signed-off-by: Junio C Hamano <>
2010-09-27perl: bump the required Perl version to 5.8 from 5.6.[21]Ævar Arnfjörð Bjarmason
Formalize our dependency on perl 5.8, bumped from 5.6.[12]. We already used the three-arg form of open() which was introduced in 5.6.1, but t/t9700/ explicitly depended on 5.6.2. However has been failing on the 5.6 line since it was introduced in v1.5.0-rc0~12^2~2 back in 2006 due to this open syntax: sub run_cmd_pipe { my $fh = undef; open($fh, '-|', @_) or die; return <$fh>; } Which when executed dies on "Can't use an undefined value as filehandle reference". Several of our tests also fail on 5.6 (even more when compiled with NO_PERL_MAKEMAKER=1): Our code is bitrotting on 5.6 with no-one interested in fixing it, and pinning us to such an ancient release of Perl is keeping us from using useful features introduced in the 5.8 release. The 5.6 series is now over 10 years old, and the 5.6.2 maintenance release almost 7. 5.8 on the other hand is more than 8 years old. All the modern Unix-like operating systems have now upgraded to it or a later version, and 5.8 packages are available for old IRIX, AIX Solaris and Tru64 systems. Signed-off-by: Ævar Arnfjörð Bjarmason <> Acked-by: Tor Arntsen <> Acked-by: Randal L. Schwartz <> Signed-off-by: Junio C Hamano <> better error messagePhilippe Bruhat (BooK)
Provide the bad directory name alongside with $! Note: $! is set if there is "No such file or directory", but isn't set if the file exists but is not a directory. Signed-off-by: Philippe Bruhat (BooK) <> Signed-off-by: Junio C Hamano <>
2010-03-05git-svn: support fetch with autocrlf onErik Faye-Lund
Before commit d3c9634e, performing a "git svn rebase" that fetched a change containing CRLFs corrupted the git-svn meta-data. This was worked around in d3c9634e by setting core.autocrlf to "false" in the per-repo config when initing the clone. However, if the config variable was later changed, the corruption would still occur. This patch tries to fix it while allowing core.autocrlf to be enabled, by disabling filters when when hashing. git-svn is currently the only call-site for hash_and_insert_object (apart from the test-suite), so changing it should be safe. Signed-off-by: Erik Faye-Lund <> Acked-by: Eric Wong <>
2010-02-04Typofixes outside documentation areaJunio C Hamano
begining -> beginning canonicalizations -> canonicalization comand -> command dewrapping -> unwrapping dirtyness -> dirtiness DISCLAMER -> DISCLAIMER explicitely -> explicitly feeded -> fed impiled -> implied madatory -> mandatory mimick -> mimic preceeding -> preceding reqeuest -> request substition -> substitution Signed-off-by: Junio C Hamano <> Always set Repository to absolute path if autodetectingFrank Lichtenheld
So far we only set it to absolute paths in some cases which lead to problems like wc_chdir not working. Signed-off-by: Frank Lichtenheld <> Acked-by: Petr Baudis <> Signed-off-by: Junio C Hamano <> Set GIT_WORK_TREE if we set GIT_DIRFrank Lichtenheld
Otherwise git will use the current directory as work tree which will lead to unexpected results if we operate in sub directory of the work tree. Signed-off-by: Frank Lichtenheld <> Acked-by: Petr Baudis <> Signed-off-by: Junio C Hamano <>
2009-04-05add --html-path to get the location of installed HTML docsMarkus Heidelberg
This can be used in GUIs to open installed HTML documentation in the browser. Signed-off-by: Markus Heidelberg <> Signed-off-by: Junio C Hamano <>
2009-01-14Merge branch 'maint'Junio C Hamano
* maint: fast-import: Cleanup mode setting. call Error::Simple() properly
2009-01-14Merge branch 'maint-1.6.0' into maintJunio C Hamano
* maint-1.6.0: fast-import: Cleanup mode setting. call Error::Simple() properly call Error::Simple() properlyJay Soffian
The error message to Error::Simple() must be passed as a single argument. Signed-off-by: Jay Soffian <> Signed-off-by: Junio C Hamano <> correctly handle directory name that evaluates to "false"Philippe Bruhat (BooK)
The repository constructor mistakenly rewrote a Directory parameter that Perl happens to evaluate to false (e.g. "0") to ".". Signed-off-by: Junio C Hamano <>
2008-12-22Always show which directory is not a git repositoryRichard Hartmann
Unify all fatal: Not a git repository error messages so they include path information. Signed-off-by: Richard Hartmann <> Signed-off-by: Junio C Hamano <> Make _temp_cache use the repository directoryMarten Svanfeldt (dev)
Update the usage of File::Temp->tempfile to place the temporary files within the repository directory instead of just letting Perl decide what directory to use, given there is a repository specified when requesting the temporary file. This is needed to be able to fix git-svn on msys as msysperl generates paths with UNIX-style paths (/tmp/xxx) while the git tools expect natvie path format (c:/..). The repository dir is stored in native format so by using it as the base directory for temporary files we always get a usable native full path. Signed-off-by: Marten Svanfeldt <> Acked-by: Eric Wong <> do not break inheritanceChristian Jaeger
Make it possible to write subclasses of Signed-off-by: Christian Jaeger <> Signed-off-by: Junio C Hamano <> Use File::Temp->tempfile instead of ->newMarcus Griep
Perl 5.8.0 ships with File::Temp 0.13, which does not have the new() interface introduced in 0.14, as pointed out by Tom G. Christensen. This modifies to use the more established tempfile() interface and updates 'git svn' to match. Signed-off-by: Marcus Griep <> Acked-by: Eric Wong <> Tested-by: Tom G. Christensen <> Signed-off-by: Junio C Hamano <> Make File::Spec and File::Temp requirement lazyMarcus Griep
This will ensure that the API at large is accessible to nearly all Perl versions, while only the temp file caching API is tied to the File::Temp and File::Spec modules being available. Signed-off-by: Marcus Griep <> Signed-off-by: Junio C Hamano <> Add faculties to allow temp files to be cachedMarcus Griep
This patch offers a generic interface to allow temp files to be cached while using an instance of the 'Git' package. If many temp files are created and destroyed during the execution of a program, this caching mechanism can help reduce the amount of files created and destroyed by the filesystem. The temp_acquire method provides a weak guarantee that a temp file will not be stolen by subsequent requests. If a file is locked when another acquire request is made, a simple error is thrown. Signed-off-by: Marcus Griep <> Acked-by: Eric Wong <>
2008-08-05Fix typo in perl/Git.pmAbhijit Menon-Sen
Signed-off-by: Abhijit Menon-Sen <> Signed-off-by: Junio C Hamano <>
2008-08-05Fix hash slice syntax errorAbhijit Menon-Sen
Signed-off-by: Abhijit Menon-Sen <> Signed-off-by: Junio C Hamano <> localise $? in command_close_bidi_pipe()Abhijit Menon-Sen
Git::DESTROY calls _close_cat_blob and _close_hash_and_insert_object, which in turn call command_close_bidi_pipe, which calls waitpid, which alters $?. If this happens during global destruction, it may alter the program's exit status unexpectedly. Making $? local to the function solves the problem. (The problem was discovered due to a failure of test #8 in Signed-off-by: Abhijit Menon-Sen <> Signed-off-by: Junio C Hamano <>
2008-07-30Replace uses of "git-var" with "git var"Todd Zullinger
Signed-off-by: Todd Zullinger <> Signed-off-by: Junio C Hamano <> Add remote_refs() git-ls-remote frontendPetr Baudis
This patch also converts the good ole' git-remote.perl to use it. It is otherwise used in the machinery and I guess other scripts might find it useful too. Unfortunately, git-ls-remote --heads . is subtly different from git-ls-remote . refs/heads/ (since the second matches anywhere in the string, not just at the beginning) so we have to provide interface for both. Signed-off-by: Petr Baudis <> Signed-off-by: Junio C Hamano <> fix return value of config methodLea Wiemann
If config is called in array context, it is supposed to return all values set for the given option key. This works for all cases except if there is no value set at all. In that case, it wrongly returns (undef) instead of (). This fixes the return statement so that it returns undef in scalar context but an empty array in array context. Signed-off-by: Lea Wiemann <> Signed-off-by: Junio C Hamano <> fix documentation of hash_objectLea Wiemann
The documentation of hash_object incorrectly states that it accepts a file handle -- in fact it doesn't, and there is even a TODO comment for this. This fixes the documentation. Signed-off-by: Lea Wiemann <> Signed-off-by: Junio C Hamano <>
2008-05-28Git::cat_blob: allow using an empty blob to fix git-svn breakageJunio C Hamano
Recent "git-svn optimization" series introduced Git::cat_blob() subroutine whose interface was broken in that it returned the size of the blob but signalled an error by returning 0. You can never use an empty blob with such an interface. This fixes the interface to return a negative value to signal an error. Reported by Björn Steinbrink. Signed-off-by: Junio C Hamano <> Add hash_and_insert_object and cat_blobAdam Roben
These functions are more efficient ways of executing `git hash-object -w` and `git cat-file blob` when you are dealing with many files/objects. Signed-off-by: Adam Roben <> Signed-off-by: Junio C Hamano <> Add command_bidi_pipe and command_close_bidi_pipeAdam Roben
command_bidi_pipe hands back the stdin and stdout file handles from the executed command. command_close_bidi_pipe closes these handles and terminates the process. Signed-off-by: Adam Roben <> Signed-off-by: Junio C Hamano <> Don't require repository instance for identFrank Lichtenheld
git var doesn't require to be called in a repository anymore, so don't require it either. Signed-off-by: Frank Lichtenheld <> Signed-off-by: Junio C Hamano <> Don't require a repository instance for configFrank Lichtenheld
git config itself doesn't require to be called in a repository, so don't add arbitrary restrictions. Signed-off-by: Frank Lichtenheld <> Signed-off-by: Junio C Hamano <>
2007-12-06Color support for "git-add -i"Junio C Hamano
This is mostly lifted from earlier series by Dan Zwell, but updated to use "git config --get-color" and "git config --get-colorbool" to make it simpler and more consistent with commands written in C. A new configuration color.interactive variable is like color.diff and color.status, and controls if "git-add -i" uses color. A set of configuration variables, color.interactive.<slot>, are used to define what color is used for the prompt, header, and help text. For perl scripts, provides $repo->get_color() method, which takes the slot name and the default color, and returns the terminal escape sequence to color the output text. $repo->get_colorbool() method can be used to check if color is set to be used for a given operation. Signed-off-by: Junio C Hamano <>
2007-11-30Add config_int() method to the Git perl moduleJakub Narebski
Integer variables can have optional 'k', 'm' or 'g' suffix. config_int() method will return simple decimal number, taking care of those suffixes. Signed-off-by: Jakub Narebski <> Signed-off-by: Junio C Hamano <>
2007-11-07When exec() fails include the failing command in the error messageAsk Bjørn Hansen
git-svn occasionally fails with no details as to what went wrong - this should help debug those situations. Signed-off-by: Ask Bjørn Hansen <> Signed-off-by: Junio C Hamano <>
2007-08-22Fix git-remote for ActiveState PerlAlex Riesen
For reason unknown a package in ActiveState Perl 5.8.7 must implement READLINE method differently for scalar and array context. The code tested to work for more sane and recent version of perl (5.8.8 shipped with Ubuntu), so maybe it was always a requirement. Signed-off-by: Alex Riesen <> Signed-off-by: Junio C Hamano <> config_boolean() -> config_bool()Petr Baudis
This patch renames config_boolean() to config_bool() for consistency with the commandline interface and because it is shorter but still obvious. ;-) It also changes the return value from some obscure string to real Perl boolean, allowing for clean user code. Signed-off-by: Petr Baudis <>
2007-02-21Add config_boolean() method to the Git perl moduleTheodore Ts'o
Signed-off-by: "Theodore Ts'o" <> Signed-off-by: Junio C Hamano <>
2007-02-04Assorted typo fixesPavel Roskin
Signed-off-by: Junio C Hamano <>
2007-01-29[PATCH] Rename git-repo-config to git-config.Tom Prince
Signed-off-by: Tom Prince <> Signed-off-by: Junio C Hamano <>
2007-01-22Cleanup uninitialized value in chompAlex Riesen
which happens if you use ActiveState Perl and a pipe workaround specially for it. Signed-off-by: Alex Riesen <> Signed-off-by: Junio C Hamano <>
2007-01-22Force Activestate Perl to tie git command pipe handle to a handle classAlex Riesen
Otherwise it tries to tie it to a scalar and complains about missing method. Dunno why, may be ActiveState brokenness again. Signed-off-by: Alex Riesen <> Acked-by: Petr Baudis <> Signed-off-by: Junio C Hamano <>
2007-01-22Insert ACTIVESTATE_STRING in Git.pmAlex Riesen
Also add "git" to the pipe parameters, otherwise it does not work at all, as no git commands are usable out of git context. Signed-off-by: Alex Riesen <> Signed-off-by: Junio C Hamano <>
2007-01-12use 'init' instead of 'init-db' for shipped docs and toolsNicolas Pitre
While 'init-db' still is and probably will always remain a valid git command for obvious backward compatibility reasons, it would be a good idea to move shipped tools and docs to using 'init' instead. Signed-off-by: Nicolas Pitre <> Signed-off-by: Junio C Hamano <> Kill Git.xs for nowPetr Baudis
This patch removes Git.xs from the repository for the time being. This should hopefully enable to finally make its way to master. Git.xs is not going away forever. When the Git libification makes some progress, it will hopefully return (but most likely as an optional component, due to the portability woes) since the performance boosts are really important for applications like Gitweb or Cogito. It needs to go away now since it is not really reliable in case you use it for several repositories in the scope of a single process, and that is not possible to fix without some either very ugly or very intrusive core changes. Rest in peace. (While you can.) Signed-off-by: Petr Baudis <> Signed-off-by: Junio C Hamano <>
2006-09-03Revert "Make it possible to set up libgit directly (instead of from the ↵Junio C Hamano
environment)" This reverts commit 0270083ded143fd49841e3d3d0cac5eb06081d2a.
2006-09-03Revert " Introduce fast get_object() method"Junio C Hamano
This reverts commit 3c479c37f8651d09e1d08b8d6ea9757164ee1235. Introduce fast get_object() methodPetr Baudis
Direct .xs routine. Note that it does not work 100% correctly when you juggle multiple repository objects, but it is not that bad either. The trouble is that we might reuse packs information for another Git project; that is not an issue since Git depends on uniqueness of SHA1 ids so if we have found the object somewhere else, it is nevertheless going to be the same object. It merely makes object existence detection through this method unreliable; it is duly noted in the documentation. At least that's how I see it, I hope I didn't overlook any other potential problem. I tested it for memory leaks and it appears to be doing ok. Signed-off-by: Petr Baudis <> Signed-off-by: Junio C Hamano <>
2006-07-09Make it possible to set up libgit directly (instead of from the environment)Petr Baudis
This introduces a setup_git() function which is essentialy a (public) backend for setup_git_env() which lets anyone specify custom sources for the various paths instead of environment variables. Since the repositories may get switched on the fly, this also updates code that caches paths to invalidate them properly; I hope neither of those is a sweet spot. It is used by Git.xs' xs__call_gate() to set up per-repository data for libgit's consumption. No code actually takes advantage of it yet but get_object() will in the next patches. Signed-off-by: Petr Baudis <> Signed-off-by: Junio C Hamano <> Introduce ident() and ident_person() methodsPetr Baudis
These methods can retrieve/parse the author/committer ident. Signed-off-by: Petr Baudis <> Signed-off-by: Junio C Hamano <> Add config() methodPetr Baudis
This accessor will retrieve value(s) of the given configuration variable. Signed-off-by: Petr Baudis <> Signed-off-by: Junio C Hamano <> Remove PerlIO usage from Git.xsPetr Baudis
PerlIO_*() is not portable before 5.7.3, according to ppport.h, and it's more clear what is going on when we do it in the Perl part of the Git module anyway. Signed-off-by: Petr Baudis <> Signed-off-by: Junio C Hamano <>