path: root/builtin-reset.c
AgeCommit message (Collapse)Author
2008-03-05Make builtin-reset.c use parse_options.Carlos Rica
Signed-off-by: Carlos Rica <> Signed-off-by: Junio C Hamano <>
2008-03-02Clean up find_unique_abbrev() callersJunio C Hamano
Now find_unique_abbrev() never returns NULL, there is no need for callers to prepare for seeing NULL and fall back to giving the full 40-hexdigits. While we are at it, drop "..." in the "git reset" output that reports the location of the new HEAD, between the abbreviated commit object name and the one line commit summary. Because we are always showing the HEAD (which cannot be missing!), we never had a case where we show the full 40 hexdigits that is not followed by three dots, and these three dots were stealing 3 columns from the precious horizontal screen real estate out of 80 that can better be used for the one line commit summary. Signed-off-by: Junio C Hamano <>
2008-02-10Move code to clean up after a branch change to branch.cDaniel Barkalow
Signed-off-by: Daniel Barkalow <>
2008-02-10Library function to check for unmerged index entriesDaniel Barkalow
It's small, but it was in three places already, so it should be in the library. Signed-off-by: Daniel Barkalow <>
2008-01-16Improve use of lockfile APIBrandon Casey
Remove remaining double close(2)'s. i.e. close() before commit_locked_index() or commit_lock_file(). Signed-off-by: Junio C Hamano <>
2008-01-02git-reset: refuse to do hard reset in a bare repositoryJeff King
It makes no sense since there is no working tree. A soft reset should be fine, though. Signed-off-by: Jeff King <> Signed-off-by: Junio C Hamano <>
2007-12-12Fix small memory leaks induced by diff_tree_setup_pathsMike Hommey
Run diff_tree_release_paths in the appropriate places, and add a test to avoid NULL dereference. Better safe than sorry. Signed-off-by: Mike Hommey <> Signed-off-by: Junio C Hamano <>
2007-11-11Merge branch 'js/reset'Junio C Hamano
* js/reset: builtin-reset: avoid forking "update-index --refresh" builtin-reset: do not call "ls-files --unmerged"
2007-11-06git-reset: add -q option to operate quietlyGerrit Pape
Many git commands have a -q option to suppress output to stdout, let's have it for git-reset too. This was asked for by Joey Hess through Signed-off-by: Gerrit Pape <> Signed-off-by: Junio C Hamano <>
2007-11-06builtin-reset: avoid forking "update-index --refresh"Johannes Schindelin
Instead of forking update-index, call refresh_cache() directly. Signed-off-by: Johannes Schindelin <> Signed-off-by: Junio C Hamano <>
2007-11-06builtin-reset: do not call "ls-files --unmerged"Johannes Schindelin
Since reset is a builtin now, it can use the full power of libgit.a and check for unmerged entries itself. Signed-off-by: Johannes Schindelin <> Signed-off-by: Junio C Hamano <>
2007-11-04git-reset: do not be confused if there is nothing to resetJohannes Schindelin
The purpose of the function update_index_from_diff() (which is the callback function we give do_diff_cache()) is to update those index entries which differ from the given commit. Since do_diff_cache() plays games with the in-memory index, this function discarded the cache and reread it. Then, back in the function read_from_tree() we wrote the index. Of course, this broke down when there were no changes and update_index_from_diff() was not called, and therefore the mangled index was not discarded. The solution is to move the index writing into the function update_index_from_diff(). Noticed by Björn Steinbrink. Signed-off-by: Johannes Schindelin <> Signed-off-by: Junio C Hamano <>
2007-10-21Improved const correctness for stringsShawn O. Pearce
Signed-off-by: Shawn O. Pearce <>
2007-09-12Make "git reset" a builtin.Carlos Rica
This replaces the script "" with "builtin-reset.c". A few git commands used in the script are called from the builtin also: "ls-files" to check for unmerged files, "read-tree" for resetting the index file in "mixed" and "hard" resets, and "update-index" to refresh at the end in the "mixed" reset and also for the option that gets selected paths into the index. The reset option with paths was implemented by Johannes Schindelin. Since the option that gets selected paths into the index is not a "reset" like the others because it does not change the HEAD at all, now the command is showing a warning when the "--mixed" option is supplied for that purpose. The following table shows the behaviour of "git reset" for the different supported options, where X means "changing" the HEAD, index or working tree: reset: --soft --mixed --hard -- <paths> HEAD X X X - index - X X X files - - X - Signed-off-by: Carlos Rica <> Signed-off-by: Junio C Hamano <>