AgeCommit message (Collapse)Author
2010-09-29stash drops the stash even if creating the branch fails because it already ↵Tomas Carnecky
exists This bug was disovered by someone on IRC when he tried to $ git stash branch <branch> <stash> while <branch> already existed. In that case the stash is dropped even though it isn't applied on any branch, so the stash is effectively lost. Signed-off-by: Tomas Carnecky <> Signed-off-by: Junio C Hamano <>
2010-09-27Fix missing 'does' in man-page for 'git checkout'Linus Torvalds
Reported-by: Rainer Standke <> Signed-off-by: Linus Torvalds <> Signed-off-by: Junio C Hamano <>
2010-09-27dir.c: squelch false uninitialized memory warningPat Notz
GCC 4.4.4 on MacOS incorrectly warns about potential use of uninitialized memory. Signed-off-by: Pat Notz <> Signed-off-by: Junio C Hamano <>
2010-09-27git-send-email.perl: ensure $domain is defined before using itBrandon Casey
valid_fqdn() may attempt to operate on an undefined value if Net::Domain::domainname fails to determine the domain name. This causes perl to emit unpleasant warnings. So, add a check for whether $domain has been defined before using it. Signed-off-by: Brandon Casey <> Signed-off-by: Junio C Hamano <>
2010-09-27wt-status.c: don't leak directory entries when processing untracked,ignoredBrandon Casey
When iterating through the list of directory entries, searching for untracked entries, only the entries added to the string_list were free'd. The rest (tracked or not matching the pathspec) were leaked. Ditto for the "ignored" loop. Rearrange the loops so that all entries are free'd. Signed-off-by: Brandon Casey <> Signed-off-by: Junio C Hamano <>
2010-09-27t6050 (replace): fix bogus "fetch branch with replacement" testChristian Couder
The test was missing some "&&" at the end of some lines and it was wrong because, as the replacement refs were not fetched, the commits from the parallel branch should not show up. This was found by Elijah Newren. This is fixed by checking that after the branch from HASH6 is fetched, the commits from the parallel branch don't show up, and then by fetching the replacement refs and checking that they do show up afterwards. Signed-off-by: Christian Couder <> Signed-off-by: Junio C Hamano <>
2010-09-27Documentation: Refer to git-commit-tree in git-filter-branch helpWesley J. Landaker
Currently, the help for git filter-branch refers users of --env-filter to git-commit for information about environment variables affecting commits. However, this information is not contained in the git-commit help, but is very explicitly detailed in git-commit-tree. Signed-off-by: Wesley J. Landaker <> Signed-off-by: Junio C Hamano <>
2010-09-27update comment and documentation for :/foo syntaxMatthieu Moy
The documentation in revisions.txt did not match the implementation, and the comment in sha1_name.c was incomplete. Signed-off-by: Matthieu Moy <> Signed-off-by: Junio C Hamano <>
2010-09-27Improvements to `git checkout -h`Daniel Knittl-Frank
be a little more verbose about what each option does Signed-off-by: Daniel Knittl-Frank <> Reviewed-by: Matthieu Moy <> Signed-off-by: Junio C Hamano <>
2010-09-27contrib/completion: --no-index option to git diffMichael J Gruber
Signed-off-by: Michael J Gruber <> Signed-off-by: Junio C Hamano <>
2010-09-27prefer test -h over test -L in shell scriptsJeff King
Even though "-L" is POSIX, the former is more portable, and we tend to prefer it already. Signed-off-by: Jeff King <> Signed-off-by: Junio C Hamano <>
2010-09-27CodingGuidelines: spell Arithmetic Expansion with $(($var))Junio C Hamano
POSIX wants shells to support both "N" and "$N" and requires them to yield the same answer to $((N)) and $(($N)), but we should aim for portability in a case like this, especially when the price we pay to do so is so small, i.e. a few extra dollars. Signed-off-by: Junio C Hamano <>
2010-09-27t1503: Fix arithmetic expansion syntax error when using dashRamsay Jones
On systems which have dash as /bin/sh, such as Ubuntu, the final test (master@{n} for various n) fails with a syntax error while processing an arithmetic expansion. The syntax error is caused by using a bare name ('N') as a variable reference in the expression. In order to avoid the syntax error, we spell the variable reference as '$N' rather than simply 'N'. Signed-off-by: Ramsay Jones <> Signed-off-by: Junio C Hamano <>
2010-09-27remote-helpers: build in platform independent directoryMichael J Gruber
The build directory which is used by distutils depends on the platform (e.g. build/lib on Fedora 13, build/lib.linux-i686-2.6 on Ubuntu 9.04). But expects to find the build in build/lib which can cause to fail early. Override distutils' choice so that the build is always in build/lib. Signed-off-by: Michael J Gruber <> Signed-off-by: Junio C Hamano <>
2010-09-27strbuf.h: fix comment typoPat Notz
Signed-off-by: Pat Notz <> Signed-off-by: Junio C Hamano <>
2010-09-27git-stash: fix flag parsingBrian Gernhardt
Currently git-stash uses `git rev-parse --no-revs -- "$@"` to set its FLAGS variable. This is the same as `FLAGS="-- $@"`. It should use `git rev-parse --no-revs --flags "$@"`, but that eats any "-q" or "--quiet" argument. So move the check for quiet before rev-parse. Signed-off-by: Brian Gernhardt <> Signed-off-by: Junio C Hamano <>
2010-09-27t/t3903-stash: improve testing of git-stash showBrandon Casey
Recently, the 'stash show' functionality was broken for the case when a stash-like argument was supplied. Since, commit 9bf09e, 'stash show' when supplied a stash-like argument prints nothing and still exists with a zero status. Unfortunately, the flaw slipped through the test suite cracks since the output of 'stash show' was not verified to be correct. Improve and expand on the existing tests so that this flaws is detected. Signed-off-by: Brandon Casey <> Signed-off-by: Junio C Hamano <>
2010-09-24git-svn: fix processing of decorated commit hashesMathias Lafeldt
The function working_head_info() fails to parse commit hashes if they are decorated (i.e. log.decorate is true), causing dcommit, rebase, and other vital git-svn commands to malfunction. This patch disables decorated log output with --no-decorate. [ew: wrapped long line] Signed-off-by: Mathias Lafeldt <> Acked-by: Eric Wong <>
2010-09-24git-svn: check_cherry_pick should exclude commits already in our historySteven Walter
The merge-base between @$parents and $merge_tip may have been reached through a merge commit. This means that some commits that are ancestors of @$parents will not be ancestors of $merge_base. The mergeinfo property will not list commits that are ancestors of @$parents, so we need to explicitly exclude them. [ew: squashed and cleaned up test case from Steven] Signed-off-by: Steven Walter <> Acked-by: Eric Wong <>
2010-09-24Documentation/git-svn: discourage "noMetadata"Eric Wong
"noMetadata" is a sometimes harmful option, so better document its behavior and limitations. Suggested-by: Vadim Zeitlin Signed-off-by: Eric Wong <>
2010-09-18Git 1.7.3v1.7.3Junio C Hamano
Signed-off-by: Junio C Hamano <>
2010-09-18Merge branch 'js/ls-files-x-doc'Junio C Hamano
* js/ls-files-x-doc: ls-files documentation: reword for consistency git-ls-files.txt: clarify -x/--exclude option Conflicts: Documentation/git-ls-files.txt replace cut with ${v%% *}Chris Johnsen
Some versions of cut do not cope well with lines that do not end in an LF. In this case, we can completely avoid cut by using the ${var%% *} parameter expansion (suggested by Brandon Casey). I found this problem when t3404's "avoid unnecessary reset" failed due to the "rebase -i" not avoiding updating the tested timestamp. On a Mac OS X 10.4.11 system: % printf '%s' 'foo bar' | /usr/bin/cut -d ' ' -f 1 cut: stdin: Illegal byte sequence Signed-off-by: Chris Johnsen <> Signed-off-by: Junio C Hamano <>
2010-09-17t/t7300: workaround ancient touch by rearranging argumentsBrandon Casey
The ancient touch on Solaris 7 thinks that a decimal number supplied as the first argument specifies a date_time to give to the files specified by the remaining arguments. In this case, it fails to parse '1' as a proper date_time and exits with a failure status. Workaround this flaw by rearranging the arguments supplied to touch so that a non-digit appears first and touch will not be confused. Signed-off-by: Brandon Casey <> Signed-off-by: Junio C Hamano <>
2010-09-16Merge branch 'bg/fix-t7003'Junio C Hamano
* bg/fix-t7003: t7003: Use test_commit instead of custom function
2010-09-16ls-files documentation: reword for consistencyJunio C Hamano
Similar to descriptions of other options, state what -x does in imperative mood. Start sentences for -X and --exclude-per-directory options in capital letters. Signed-off-by: Junio C Hamano <>
2010-09-16git-ls-files.txt: clarify -x/--exclude optionJay Soffian
Since b5227d8, -x/--exclude does not apply to cached files. This is easy to miss unless you read the discussion in the EXCLUDE PATTERNS section. Clarify that the option applies to untracked files and direct the reader to EXCLUDE PATTERNS. Signed-off-by: Jay Soffian <> Signed-off-by: Junio C Hamano <>
2010-09-15Git 1.7.3 rc2v1.7.3-rc2Junio C Hamano
2010-09-15Merge branch 'dr/maint-ls-tree-prefix-recursion-fix'Junio C Hamano
* dr/maint-ls-tree-prefix-recursion-fix: ls-tree $di $dir: do not mistakenly recurse into directories
2010-09-15Merge branch 'os/fix-rebase-diff-no-prefix'Junio C Hamano
* os/fix-rebase-diff-no-prefix: Add --src/dst-prefix to git-formt-patch in
2010-09-15Merge branch 'jl/fix-test'Junio C Hamano
* jl/fix-test: t1020: Get rid of 'cd "$HERE"' at the start of each test t2016 (checkout -p): add missing && t1302 (core.repositoryversion): style tweaks t2105 (gitfile): add missing && t1450 (fsck): remove dangling objects tests: subshell indentation stylefix Several tests: cd inside subshell instead of around
2010-09-15Merge branch 'ch/filter-branch-deprecate-remap-to-ancestor'Junio C Hamano
* ch/filter-branch-deprecate-remap-to-ancestor: filter-branch: retire --remap-to-ancestor
2010-09-15Merge branch 'ch/maint-cannot-create-bundle-error'Junio C Hamano
* ch/maint-cannot-create-bundle-error: bundle: detect if bundle file cannot be created
2010-09-15Merge branch 'ks/recursive-rename-add-identical'Junio C Hamano
* ks/recursive-rename-add-identical: RE: [PATCH] Avoid rename/add conflict when contents are identical
2010-09-15Merge git:// C Hamano
* 'master' of git:// git-gui 0.13 git-gui: avoid mis-encoding the copyright message on Windows. git-gui: Update Swedish translation (521t). git-gui: ensure correct application termination in git-gui--askpass git-gui: handle textconv filter on Windows and in development git-gui: use shell to launch textconv filter in "blame" git-gui: display error launching blame as a message box. git-gui: Make usage statement visible on Windows.
2010-09-14git-gui 0.13gitgui-0.13.0Pat Thoyts
Signed-off-by: Pat Thoyts <>
2010-09-13git-gui: avoid mis-encoding the copyright message on Windows.Pat Thoyts
On Windows the tcl script file will use the system encoding and attempting to convert the copyright mis-encodes the string. Instead, keep the message as ASCII and substitute in the correct unicode character when running. Signed-off-by: Pat Thoyts <>
2010-09-13git-gui: Update Swedish translation (521t).Peter Krefting
Signed-off-by: Peter Krefting <> Signed-off-by: Pat Thoyts <>
2010-09-13t7003: Use test_commit instead of custom functionBrian Gernhardt had a make_commit() function that was identical to test_commit() in except that it used tr to create a lowercase file name from the uppercase branch name instead of appending ".t". Not only is this unneeded code duplication, it also was something simply waiting to fail on case-insensitive file systems. So replace all uses of make_commit with test_commit. While we're editing the setup, chain it together with && so that failures early in the sequence don't get lost and add a commit graph. Signed-off-by: Brian Gernhardt <> Signed-off-by: Junio C Hamano <>
2010-09-12Merge branch 'maint'Junio C Hamano
* maint: t3101: modernise style compat/nedmalloc: don't force NDEBUG on the rest of git Conflicts: Makefile
2010-09-12ls-tree $di $dir: do not mistakenly recurse into directoriesJunio C Hamano
When applying two pathspecs, one of which is named as a prefix to the other, we mistakenly recursed into the shorter one. Noticed and fixed by David Reis. Signed-off-by: Junio C Hamano <>
2010-09-12t3101: modernise styleJunio C Hamano
Also add a few " &&" cascade that were missing. Signed-off-by: Junio C Hamano <>
2010-09-12vcs-svn: Fix some printf format compiler warningsRamsay Jones
In particular, on systems that define uint32_t as an unsigned long, gcc complains as follows: CC vcs-svn/fast_export.o vcs-svn/fast_export.c: In function `fast_export_modify': vcs-svn/fast_export.c:28: warning: unsigned int format, uint32_t arg (arg 2) vcs-svn/fast_export.c:28: warning: int format, uint32_t arg (arg 3) vcs-svn/fast_export.c: In function `fast_export_commit': vcs-svn/fast_export.c:42: warning: int format, uint32_t arg (arg 5) vcs-svn/fast_export.c:62: warning: int format, uint32_t arg (arg 2) vcs-svn/fast_export.c: In function `fast_export_blob': vcs-svn/fast_export.c:72: warning: int format, uint32_t arg (arg 2) vcs-svn/fast_export.c:72: warning: int format, uint32_t arg (arg 3) CC vcs-svn/svndump.o vcs-svn/svndump.c: In function `svndump_read': vcs-svn/svndump.c:260: warning: int format, uint32_t arg (arg 3) In order to suppress the warnings we use the C99 format specifier macros PRIo32 and PRIu32 from <inttypes.h>. Signed-off-by: Ramsay Jones <> Acked-by: Jonathan Nieder <> Signed-off-by: Junio C Hamano <>
2010-09-11compat/nedmalloc: don't force NDEBUG on the rest of gitRené Scharfe
Define the nedmalloc feature configuration macros for nedmalloc.o, only. This keeps assert(3) working for the rest of the git source; it was turned off for nedmalloc users before by defining NDEBUG globally. Also remove -DUSE_NED_ALLOCATOR as this macro isn't used anywhere. Signed-off-by: Rene Scharfe <> Signed-off-by: Junio C Hamano <>
2010-09-10Git 1.7.3 rc1v1.7.3-rc1Junio C Hamano
Signed-off-by: Junio C Hamano <>
2010-09-10Merge branch 'np/relnotes-in-subdir'Junio C Hamano
* np/relnotes-in-subdir: install-webdoc: keep installed RelNotes-*.txt Documentation: move RelNotes into a directory of their own
2010-09-10Prepare for 1.7.3 rc1Junio C Hamano
2010-09-10Merge branch 'maint'Junio C Hamano
* maint: config.txt: fix placement of diff.noprefix
2010-09-10config.txt: fix placement of diff.noprefixMark Lodato
In git-config(1), diff.noprefix was placed in between diff.mnemonicprefix and the list of mnemonic prefixes, which is obviously incorrect and very confusing to readers. Now, it is located after the end of the explanation of mnemonicprefix, which makes much more sense. Signed-off-by: Mark Lodato <> Signed-off-by: Junio C Hamano <>
2010-09-10t/t4018: avoid two unnecessary sub-shell invocationsBrandon Casey
Signed-off-by: Brandon Casey <> Signed-off-by: Junio C Hamano <>