AgeCommit message (Collapse)Author
2010-01-31Fix typos in technical documentation.Ralf Wildenhues
Signed-off-by: Ralf Wildenhues <> Signed-off-by: Junio C Hamano <>
2010-01-30is_submodule_modified(): fix breakage with external GIT_INDEX_FILEv1.7.0-rc1Junio C Hamano
Even when the environment was given for the top-level process, checking in the submodule work tree should use the index file associated with the work tree of the submodule. Do not export it to the environment. Signed-off-by: Junio C Hamano <>
2010-01-30RPM packaging: don't include foreign-scm-helper bits yetJunio C Hamano
The files in /usr/lib/python* are only the support infrastructure for foreign scm interface yet to be written and/or shipped with git. Don't include them in the binary package (this will also free us from Python dependency). When we ship with foreign scm interface, we will need to package these files with it in a separate subpackage, but we are not there yet. Signed-off-by: Junio C Hamano <>
2010-01-30grep: Fix two memory leaksDan McGee
We duplicate the grep_opt structure when using grep threads, but didn't later free either the patterns attached to this new structure or the structure itself. Signed-off-by: Dan McGee <> Signed-off-by: Junio C Hamano <>
2010-01-30rebase: don't invoke the pager for each commit summaryMarkus Heidelberg
This regression was introduced by commit 0aa958d (rebase: replace antiquated sed invocation, 2010-01-24), which changed the invocation of "git rev-list | sed" to "git log". It can be reproduced by something like this: $ git rebase -s recursive origin/master Signed-off-by: Markus Heidelberg <> Signed-off-by: Junio C Hamano <>
2010-01-30Update draft release notes to 1.7.0Junio C Hamano
Signed-off-by: Junio C Hamano <>
2010-01-30Merge branch 'maint'Junio C Hamano
* maint: fix memcpy of overlapping area
2010-01-30Merge branch 'maint-1.6.5' into maintJunio C Hamano
* maint-1.6.5: fix memcpy of overlapping area
2010-01-30Implement pthread_cond_broadcast on WindowsJohannes Sixt
See, section "The SignalObjectAndWait solution". But note that this implementation does not use SignalObjectAndWait (which is needed to achieve fairness, but we do not need fairness). Note that our implementations of pthread_cond_broadcast and pthread_cond_signal require that they are invoked with the mutex held that is used in the pthread_cond_wait calls. Signed-off-by: Johannes Sixt <> Signed-off-by: Junio C Hamano <>
2010-01-30If deriving SVN_SSH from GIT_SSH on msys, also add quotesSebastian Schuberth
In contrast to GIT_SSH, SVN_SSH requires quotes for paths that contain spaces. As GIT_SSH will not work if it contains quotes, it is safe to assume it never contains quotes. Also, adding quotes to SVN_SSH for paths that do not contain spaces does no harm. So we always add quotes when deriving SVN_SSH from GIT_SSH on msys. This fixes msysGit issue 385, see Signed-off-by: Sebastian Schuberth <> Signed-off-by: Junio C Hamano <>
2010-01-29Merge git:// C Hamano
* git:// gitk: Update German translation gitk: Add French translation gitk: update Italian translation gitk: Update Swedish translation gitk: Adjust two equal strings which differed in whitespace gitk: Display submodule diffs with appropriate encoding gitk: Fix display of newly-created tags gitk: Enable gitk to create tags with messages gitk: Update Hungarian translation gitk: Add Hungarian translation gitk: Add "--no-replace-objects" option
2010-01-29add shebang line to git-mergetool--lib.shJeff King
Even though this script is expected to be sourced instead of executed on its own, the #!/bin/sh line provides simple documentation about what format the file is in. In particular, the lack of such a line was confusing the valgrind support of our test scripts, which assumed that any executable without a #!-line should be intercepted and run through valgrind. So during valgrind-enabled tests, any script sourcing this file actually sourced the valgrind interception script instead. Signed-off-by: Jeff King <> Signed-off-by: Junio C Hamano <>
2010-01-29fix off-by-one allocation errorJeff King
Caught by valgrind in t5516. Reading the code shows we malloc enough for our string, but not trailing NUL. Signed-off-by: Jeff King <> Signed-off-by: Junio C Hamano <>
2010-01-29fix memcpy of overlapping areaJeff King
Caught by valgrind in t5500, but it is pretty obvious from reading the code that this is shifting elements of an array to the left, which needs memmove. Signed-off-by: Jeff King <> Signed-off-by: Junio C Hamano <>
2010-01-29gitk: Update German translationChristian Stimming
Signed-off-by: Christian Stimming <> Signed-off-by: Paul Mackerras <>
2010-01-29gitk: Add French translationEmmanuel Trillaud
Signed-off-by: Emmanuel Trillaud <> Signed-off-by: Thomas Moulard <> Signed-off-by: Guy Brand <> Signed-off-by: Nicolas Sebrecht <> Signed-off-by: Paul Mackerras <>
2010-01-29gitk: update Italian translationMichele Ballabio
Signed-off-by: Michele Ballabio <> Signed-off-by: Paul Mackerras <>
2010-01-29gitk: Update Swedish translationPeter Krefting
Signed-off-by: Peter Krefting <> Signed-off-by: Paul Mackerras <>
2010-01-28Merge branch 'maint'Junio C Hamano
* maint: bash: don't offer remote transport helpers as subcommands
2010-01-28bash: support 'git notes' and its subcommandsSZEDER Gábor
... and it will offer refs unless after -m or -F, because these two options require a non-ref argument. Signed-off-by: SZEDER Gábor <> Acked-by: Shawn O. Pearce <> Signed-off-by: Junio C Hamano <>
2010-01-28bash: don't offer remote transport helpers as subcommandsSZEDER Gábor
Since commits a2d725b7 (Use an external program to implement fetching with curl, 2009-08-05) and c9e388bb (Make the "traditionally-supported" URLs a special case, 2009-09-03) remote transport helpers like 'remote-ftp' and 'remote-curl' are offered by the completion script as available subcommands. Not good, since they are helpers, therefore should not be offered, so filter them out. Signed-off-by: SZEDER Gábor <> Acked-by: Shawn O. Pearce <> Signed-off-by: Junio C Hamano <>
2010-01-28grep --quiet: finishing touchesJunio C Hamano
Name the option "--quiet" not "--quick", document it, and add tests. Signed-off-by: Junio C Hamano <>
2010-01-28reject @{-1} not at beginning of object nameJeff King
Something like foo@{-1} is nonsensical, as the @{-N} syntax is reserved for "the Nth last branch", and is not an actual reflog selector. We should not feed such nonsense to approxidate at all. Signed-off-by: Jeff King <> Signed-off-by: Junio C Hamano <>
2010-01-28fix parsing of @{-1}@{u} combinationJeff King
Previously interpret_branch_name would see @{-1} and stop parsing, leaving the @{u} as cruft that provoked an error. Instead, we should recurse if there is more to parse. Signed-off-by: Jeff King <> Signed-off-by: Junio C Hamano <>
2010-01-28test combinations of @{} syntaxJeff King
Now that we have several different types of @{} syntax, it is a good idea to test them together, which reveals some failures. Signed-off-by: Jeff King <> Signed-off-by: Junio C Hamano <>
2010-01-28rerere: fix too-short initializationJeff King
This was caused by a typo in the sizeof parameter, and meant we looked at uninitialized memory. Caught by valgrind in t2030. Signed-off-by: Jeff King <> Signed-off-by: Junio C Hamano <>
2010-01-28t0101: use absolute dateJeff King
The original version used relative approxidates, which don't reproduce as reliably as absolute ones. Commit 6c647a fixed this for one case, but missed the "silly" case. Signed-off-by: Jeff King <> Signed-off-by: Junio C Hamano <>
2010-01-28Merge branch 'fk/threaded-grep'Junio C Hamano
* fk/threaded-grep: Threaded grep grep: expose "status-only" feature via -q
2010-01-28Merge branch 'gp/maint-cvsserver'Junio C Hamano
* gp/maint-cvsserver: git-cvsserver: allow regex metacharacters in CVSROOT
2010-01-28tests: update tests that used to failJunio C Hamano
"diff --cc" output t4038 tests was fixed by b810cbb (diff --cc: a lost line at the beginning of the file is shown incorrectly, 2009-07-22), which was actually the commit that introduced this test.. An error in "git merge -s resolve" t6035 tests was fixed by 730f728 (unpack-trees.c: look ahead in the index, 2009-09-20). Signed-off-by: Junio C Hamano <>
2010-01-27Merge branch 'jc/upstream-reflog'Junio C Hamano
* jc/upstream-reflog: Fix log -g this@{upstream}
2010-01-27Merge branch 'jc/maint-reflog-bad-timestamp'Junio C Hamano
* jc/maint-reflog-bad-timestamp: t0101: use a fixed timestamp when searching in the reflog Update @{bogus.timestamp} fix not to die() approxidate_careful() reports errorneous date string
2010-01-27Merge branch 'il/maint-colon-address'Junio C Hamano
* il/maint-colon-address: Allow use of []-wrapped addresses in git:// Support addresses with ':' in git-daemon
2010-01-27Merge branch 'il/maint-xmallocz'Junio C Hamano
* il/maint-xmallocz: Fix integer overflow in unpack_compressed_entry() Fix integer overflow in unpack_sha1_rest() Fix integer overflow in patch_delta() Add xmallocz()
2010-01-27Merge branch 'jh/maint-config-file-prefix'Junio C Hamano
* jh/maint-config-file-prefix: builtin-config: Fix crash when using "-f <relative path>" from non-root dir
2010-01-27transport_get(): drop unnecessary check for !remoteJunio C Hamano
At the beginning of the function we make sure remote is not NULL, and the remainder of the funciton already depends on it. Signed-off-by: Junio C Hamano <>
2010-01-27Fix remote.<remote>.vcsIlari Liusvaara
remote.<remote>.vcs causes remote->foreign_vcs to be set on entry to transport_get(). Unfortunately, the code assumed that any such entry is stale from previous round. Fix this by making VCS set by URL to be volatile w.r.t. transport_get() instead. Signed-off-by: Ilari Liusvaara <> Acked-by: Daniel Barkalow <> Signed-off-by: Junio C Hamano <>
2010-01-27t0101: use a fixed timestamp when searching in the reflogJunio C Hamano
That will give us a better reproducibility during tests. Signed-off-by: Junio C Hamano <>
2010-01-27Update @{bogus.timestamp} fix not to die()Junio C Hamano
The caller will say "It is not a valid object name" if it wants to, and some callers may even try to see if it names an object and otherwise try to see if it is a path. Pointed out by Jeff King. Signed-off-by: Junio C Hamano <>
2010-01-27Merge branch 'jl/diff-submodule-ignore'Junio C Hamano
* jl/diff-submodule-ignore: Teach diff --submodule that modified submodule directory is dirty git diff: Don't test submodule dirtiness with --ignore-submodules Make ce_uptodate() trustworthy again
2010-01-27work around an obnoxious bash "safety feature" on OpenBSDJunio C Hamano
Bash (4.0.24) on OpenBSD 4.6 refuses to run this snippet: $ cat #!/bin/sh one="/var/tmp/1 1" rm -f /var/tmp/1 "/var/tmp/1 1" echo hello >$one $ sh; ls /var/tmp/1* /var/tmp/1 1 $ bash; ls /var/tmp/1* line 4: $one: ambiguous redirect ls: /var/tmp/1*: No such file or directory Every competent shell programmer knows that a <$word in redirection is not subject to field splitting (POSIX.1 "2.7 Redirection" explicitly lists the kind of expansion performed: "... the word that follows the redirection operator shall be subjected to ...", and "Field Splitting" is not among them). Some clueless folks apparently decided that users need to be protected in the name of "security", however. Output from "git grep -e '> *\$' -- '*.sh'" indicates that rebase-i suffers from this bogus "safety". Work it around by surrounding the variable reference with a dq pair. Signed-off-by: Junio C Hamano <>
2010-01-26fix portability issues with $ in double quotesStephen Boyd
Using a dollar sign in double quotes isn't portable. Escape them with a backslash or replace the double quotes with single quotes. Signed-off-by: Stephen Boyd <> Signed-off-by: Junio C Hamano <>
2010-01-26approxidate_careful() reports errorneous date stringJunio C Hamano
For a long time, the time based reflog syntax (e.g. master@{yesterday}) didn't complain when the "human readable" timestamp was misspelled, as the underlying mechanism tried to be as lenient as possible. The funny thing was that parsing of "@{now}" even relied on the fact that anything not recognized by the machinery returned the current timestamp. Introduce approxidate_careful() that takes an optional pointer to an integer, that gets assigned 1 when the input does not make sense as a timestamp. As I am too lazy to fix all the callers that use approxidate(), most of the callers do not take advantage of the error checking, but convert the code to parse reflog to use it as a demonstration. Tests are mostly from Jeff King. Signed-off-by: Junio C Hamano <>
2010-01-26Fix log -g this@{upstream}Junio C Hamano
It showed the correct objects but walked a wrong reflog. Again, tests are from Jeff King. Signed-off-by: Junio C Hamano <>
2010-01-26Fix integer overflow in unpack_compressed_entry()Ilari Liusvaara
Signed-off-by: Ilari Liusvaara <> Signed-off-by: Junio C Hamano <>
2010-01-26Fix integer overflow in unpack_sha1_rest()Ilari Liusvaara
[jc: later NUL termination by the caller becomes unnecessary] Signed-off-by: Ilari Liusvaara <> Signed-off-by: Junio C Hamano <>
2010-01-26Fix integer overflow in patch_delta()Ilari Liusvaara
Signed-off-by: Ilari Liusvaara <> Signed-off-by: Junio C Hamano <>
2010-01-26Add xmallocz()Ilari Liusvaara
Add routine for allocating NUL-terminated memory block without risking integer overflow in addition of +1 for NUL byte. [jc: with suggestion from Bill Lear] Signed-off-by: Ilari Liusvaara <> Signed-off-by: Junio C Hamano <>
2010-01-26git-cvsserver: allow regex metacharacters in CVSROOTGerrit Pape
When run in a repository with a path name containing regex metacharacters (e.g. +), git-cvsserver failed to split the client request into CVSROOT and module. Now metacharacters are disabled for the value of CVSROOT in the perl regex so that directory names containing metacharacters are handled properly. Signed-off-by: Gerrit Pape <> Signed-off-by: Junio C Hamano <>
2010-01-26builtin-config: Fix crash when using "-f <relative path>" from non-root dirJohan Herland
When your current directory is not at the root of the working tree, and you use the "-f" option with a relative path, the current code tries to read from a wrong file, since argv[2] is now beyond the end of the rearranged argument list. This patch replaces the incorrect argv[2] with the variable holding the given config file name. The bug was introduced by d64ec16 (git config: reorganize to use parseopt). [jc: added test] Signed-off-by: Johan Herland <> Signed-off-by: Junio C Hamano <>