path: root/xdiff/xhistogram.c
diff options
authorPhillip Wood <>2022-02-16 10:15:06 (GMT)
committerJunio C Hamano <>2022-02-16 18:58:05 (GMT)
commit9df0fc3d578acfdeb7fa1914fcf0507adb021fa5 (patch)
treebf6cf359e110cdb44f4cf5fe048b29e540f7b5ba /xdiff/xhistogram.c
parent2b9c1209706bc2ef0ab09fb0bdc7d405e225ce8b (diff)
xdiff: fix a memory leak
Although the patience and histogram algorithms initialize the environment they do not free it if there is an error. In contrast for the Myers algorithm the environment is initalized in xdl_do_diff() and it is freed if there is an error. Fix this by always initializing the environment in xdl_do_diff() and freeing it there if there is an error. Remove the comment in do_patience_diff() about the environment being freed by xdl_diff() as it is not accurate because (a) xdl_diff() does not do that if there is an error and (b) xdl_diff() is not the only caller. Reported-by: Junio C Hamano <> Signed-off-by: Phillip Wood <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'xdiff/xhistogram.c')
1 files changed, 0 insertions, 3 deletions
diff --git a/xdiff/xhistogram.c b/xdiff/xhistogram.c
index 8079474..01decff 100644
--- a/xdiff/xhistogram.c
+++ b/xdiff/xhistogram.c
@@ -372,9 +372,6 @@ out:
int xdl_do_histogram_diff(mmfile_t *file1, mmfile_t *file2,
xpparam_t const *xpp, xdfenv_t *env)
- if (xdl_prepare_env(file1, file2, xpp, env) < 0)
- return -1;
return histogram_diff(xpp, env,
env->xdf1.dstart + 1, env->xdf1.dend - env->xdf1.dstart + 1,
env->xdf2.dstart + 1, env->xdf2.dend - env->xdf2.dstart + 1);