path: root/worktree.h
diff options
authorDenton Liu <>2019-04-29 08:28:14 (GMT)
committerJunio C Hamano <>2019-05-05 06:20:06 (GMT)
commit554544276a604c144df45efcb060c80aa322088c (patch)
treece55b3dc9ca47c326991ecfc06a2b1103f60be3a /worktree.h
parentffac537e6cbbf934b08745a378932722df287a53 (diff)
*.[ch]: remove extern from function declarations using spatch
There has been a push to remove extern from function declarations. Remove some instances of "extern" for function declarations which are caught by Coccinelle. Note that Coccinelle has some difficulty with processing functions with `__attribute__` or varargs so some `extern` declarations are left behind to be dealt with in a future patch. This was the Coccinelle patch used: @@ type T; identifier f; @@ - extern T f(...); and it was run with: $ git ls-files \*.{c,h} | grep -v ^compat/ | xargs spatch --sp-file contrib/coccinelle/noextern.cocci --in-place Files under `compat/` are intentionally excluded as some are directly copied from external sources and we should avoid churning them as much as possible. Signed-off-by: Denton Liu <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'worktree.h')
1 files changed, 10 insertions, 10 deletions
diff --git a/worktree.h b/worktree.h
index 9e3b0b7..ead36d6 100644
--- a/worktree.h
+++ b/worktree.h
@@ -30,37 +30,37 @@ struct worktree {
* The caller is responsible for freeing the memory from the returned
* worktree(s).
-extern struct worktree **get_worktrees(unsigned flags);
+struct worktree **get_worktrees(unsigned flags);
* Returns 1 if linked worktrees exist, 0 otherwise.
-extern int submodule_uses_worktrees(const char *path);
+int submodule_uses_worktrees(const char *path);
* Return git dir of the worktree. Note that the path may be relative.
* If wt is NULL, git dir of current worktree is returned.
-extern const char *get_worktree_git_dir(const struct worktree *wt);
+const char *get_worktree_git_dir(const struct worktree *wt);
* Search a worktree that can be unambiguously identified by
* "arg". "prefix" must not be NULL.
-extern struct worktree *find_worktree(struct worktree **list,
+struct worktree *find_worktree(struct worktree **list,
const char *prefix,
const char *arg);
* Return true if the given worktree is the main one.
-extern int is_main_worktree(const struct worktree *wt);
+int is_main_worktree(const struct worktree *wt);
* Return the reason string if the given worktree is locked or NULL
* otherwise.
-extern const char *worktree_lock_reason(struct worktree *wt);
+const char *worktree_lock_reason(struct worktree *wt);
@@ -68,27 +68,27 @@ extern const char *worktree_lock_reason(struct worktree *wt);
* Return zero if the worktree is in good condition. Error message is
* returned if "errmsg" is not NULL.
-extern int validate_worktree(const struct worktree *wt,
+int validate_worktree(const struct worktree *wt,
struct strbuf *errmsg,
unsigned flags);
* Update worktrees/xxx/gitdir with the new path.
-extern void update_worktree_location(struct worktree *wt,
+void update_worktree_location(struct worktree *wt,
const char *path_);
* Free up the memory for worktree(s)
-extern void free_worktrees(struct worktree **);
+void free_worktrees(struct worktree **);
* Check if a per-worktree symref points to a ref in the main worktree
* or any linked worktree, and return the worktree that holds the ref,
* or NULL otherwise. The result may be destroyed by the next call.
-extern const struct worktree *find_shared_symref(const char *symref,
+const struct worktree *find_shared_symref(const char *symref,
const char *target);