path: root/vcs-svn
diff options
authorRamsay Jones <>2011-04-07 18:49:33 (GMT)
committerJunio C Hamano <>2011-04-22 17:04:27 (GMT)
commitc51477229ee4c7846d40a447860b5bf94aa1103d (patch)
tree4bfce447467267ad409f75e33f5cb5d3ec6689d3 /vcs-svn
parent0bcd9ae85d7e05e78a10a69a2ebe98dcde130937 (diff)
sparse: Fix some "symbol not declared" warnings
In particular, sparse issues the "symbol 'a_symbol' was not declared. Should it be static?" warnings for the following symbols: attr.c:468:12: 'git_etc_gitattributes' attr.c:476:5: 'git_attr_system' vcs-svn/svndump.c:282:6: 'svndump_read' vcs-svn/svndump.c:417:5: 'svndump_init' vcs-svn/svndump.c:432:6: 'svndump_deinit' vcs-svn/svndump.c:445:6: 'svndump_reset' The symbols in attr.c only require file scope, so we add the static modifier to their declaration. The symbols in vcs-svn/svndump.c are external symbols, and they already have extern declarations in the "svndump.h" header file, so we simply include the header in svndump.c. Signed-off-by: Ramsay Jones <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'vcs-svn')
1 files changed, 1 insertions, 0 deletions
diff --git a/vcs-svn/svndump.c b/vcs-svn/svndump.c
index 572a995..bc79222 100644
--- a/vcs-svn/svndump.c
+++ b/vcs-svn/svndump.c
@@ -13,6 +13,7 @@
#include "line_buffer.h"
#include "string_pool.h"
#include "strbuf.h"
+#include "svndump.h"
* Compare start of string to literal of equal length;