diff options
| author | Jonathan Nieder <jrnieder@gmail.com> | 2011-05-27 09:07:44 (GMT) |
|---|---|---|
| committer | Jonathan Nieder <jrnieder@gmail.com> | 2011-06-15 07:15:22 (GMT) |
| commit | fbdd4f6fb477885e4bf81658e02c3542a861c695 (patch) | |
| tree | 4284cbc220ef15c28474e3203448fd60397c68d5 /vcs-svn/sliding_window.c | |
| parent | b747e5675db5e26292c942146a25e1c26440c5f7 (diff) | |
| download | git-fbdd4f6fb477885e4bf81658e02c3542a861c695.zip git-fbdd4f6fb477885e4bf81658e02c3542a861c695.tar.gz git-fbdd4f6fb477885e4bf81658e02c3542a861c695.tar.bz2 | |
vcs-svn: cap number of bytes read from sliding view
Introduce a "max_off" field in struct sliding_view, roughly
representing a maximum number of bytes that can be read from "file".
If it is set to a nonnegative integer, a call to move_window()
attempting to put the right endpoint beyond that offset will return
an error instead.
The idea is to use this when applying Subversion-format deltas to
prevent reads past the end of the preimage (which has known length).
Without such a check, corrupt deltas would cause svn-fe to block
indefinitely when data in the input pipe is exhausted.
Inspired-by: Ramkumar Ramachandra <artagnon@gmail.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Diffstat (limited to 'vcs-svn/sliding_window.c')
| -rw-r--r-- | vcs-svn/sliding_window.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/vcs-svn/sliding_window.c b/vcs-svn/sliding_window.c index 1b8d987..1bac7a4 100644 --- a/vcs-svn/sliding_window.c +++ b/vcs-svn/sliding_window.c @@ -54,6 +54,8 @@ int move_window(struct sliding_view *view, off_t off, size_t width) return -1; if (off < view->off || off + width < view->off + view->width) return error("invalid delta: window slides left"); + if (view->max_off >= 0 && view->max_off < off + width) + return error("delta preimage ends early"); file_offset = view->off + view->buf.len; if (off < file_offset) { |