diff options
| author | Denton Liu <liu.denton@gmail.com> | 2019-04-29 08:28:14 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2019-05-05 06:20:06 (GMT) |
| commit | 554544276a604c144df45efcb060c80aa322088c (patch) | |
| tree | ce55b3dc9ca47c326991ecfc06a2b1103f60be3a /upload-pack.h | |
| parent | ffac537e6cbbf934b08745a378932722df287a53 (diff) | |
| download | git-554544276a604c144df45efcb060c80aa322088c.zip git-554544276a604c144df45efcb060c80aa322088c.tar.gz git-554544276a604c144df45efcb060c80aa322088c.tar.bz2 | |
*.[ch]: remove extern from function declarations using spatch
There has been a push to remove extern from function declarations.
Remove some instances of "extern" for function declarations which are
caught by Coccinelle. Note that Coccinelle has some difficulty with
processing functions with `__attribute__` or varargs so some `extern`
declarations are left behind to be dealt with in a future patch.
This was the Coccinelle patch used:
@@
type T;
identifier f;
@@
- extern
T f(...);
and it was run with:
$ git ls-files \*.{c,h} |
grep -v ^compat/ |
xargs spatch --sp-file contrib/coccinelle/noextern.cocci --in-place
Files under `compat/` are intentionally excluded as some are directly
copied from external sources and we should avoid churning them as much
as possible.
Signed-off-by: Denton Liu <liu.denton@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'upload-pack.h')
| -rw-r--r-- | upload-pack.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/upload-pack.h b/upload-pack.h index cab2178..bc2ceb2 100644 --- a/upload-pack.h +++ b/upload-pack.h @@ -13,11 +13,11 @@ void upload_pack(struct upload_pack_options *options); struct repository; struct argv_array; struct packet_reader; -extern int upload_pack_v2(struct repository *r, struct argv_array *keys, +int upload_pack_v2(struct repository *r, struct argv_array *keys, struct packet_reader *request); struct strbuf; -extern int upload_pack_advertise(struct repository *r, +int upload_pack_advertise(struct repository *r, struct strbuf *value); #endif /* UPLOAD_PACK_H */ |