path: root/upload-pack.c
diff options
authorShawn O. Pearce <>2011-03-14 23:48:39 (GMT)
committerJunio C Hamano <>2011-03-15 00:27:25 (GMT)
commit49bee717f7080f99d3405682cc43ad525dde0973 (patch)
treecb193a31ca95a8f31f1e7f70dd8f07d02eda09c3 /upload-pack.c
parent7ed863a85a6ce2c4ac4476848310b8f917ab41f9 (diff)
upload-pack: More aggressively send 'ACK %s ready'
If a client is merely following the remote (and has not made any new commits itself), all "have %s" lines sent by the client will be common to the server. As all lines are common upload-pack never calls ok_to_give_up() and does not compute if it has a good cut point in the commit graph. Without this computation the following client is going to send all tagged commits, as these were determined to be COMMON_REF during the initial advertisement, but the client does not parse their history to transitively pass the COMMON flag and empty its queue of commits. For git.git with 339 commit tags, it takes clients 11 rounds of negotation to fully send all tagged commits and exhaust its queue of things to send as common. This is pretty slow for a client that has not done any local development activity. Force computing ok_to_give_up() and send "ACK %s ready" at the end of the current round if this round only contained common objects and ok_to_give_up() was therefore not called. This may allow the client to break early, avoiding transmission of the COMMON_REFs. Signed-off-by: Shawn O. Pearce <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'upload-pack.c')
1 files changed, 9 insertions, 0 deletions
diff --git a/upload-pack.c b/upload-pack.c
index b40a43f..11c3849 100644
--- a/upload-pack.c
+++ b/upload-pack.c
@@ -429,6 +429,8 @@ static int get_common_commits(void)
static char line[1000];
unsigned char sha1[20];
char last_hex[41];
+ int got_common = 0;
+ int got_other = 0;
save_commit_buffer = 0;
@@ -437,16 +439,22 @@ static int get_common_commits(void)
if (!len) {
+ if (multi_ack == 2 && got_common
+ && !got_other && ok_to_give_up())
+ packet_write(1, "ACK %s ready\n", last_hex);
if ( == 0 || multi_ack)
packet_write(1, "NAK\n");
if (stateless_rpc)
+ got_common = 0;
+ got_other = 0;
strip(line, len);
if (!prefixcmp(line, "have ")) {
switch (got_sha1(line+5, sha1)) {
case -1: /* they have what we do not */
+ got_other = 1;
if (multi_ack && ok_to_give_up()) {
const char *hex = sha1_to_hex(sha1);
if (multi_ack == 2)
@@ -456,6 +464,7 @@ static int get_common_commits(void)
+ got_common = 1;
memcpy(last_hex, sha1_to_hex(sha1), 41);
if (multi_ack == 2)
packet_write(1, "ACK %s common\n", last_hex);