diff options
| author | Elijah Newren <newren@gmail.com> | 2020-03-27 00:48:47 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2020-03-27 18:33:29 (GMT) |
| commit | fa0bde45cdebee8bac95e66e4bf5ba16c77fbdba (patch) | |
| tree | fb8a740cf962f7dbc24bfef01300753d467ee5ba /unpack-trees.h | |
| parent | d61633ae186d26ab2c216108c917ec0ae7dd2782 (diff) | |
| download | git-fa0bde45cdebee8bac95e66e4bf5ba16c77fbdba.zip git-fa0bde45cdebee8bac95e66e4bf5ba16c77fbdba.tar.gz git-fa0bde45cdebee8bac95e66e4bf5ba16c77fbdba.tar.bz2 | |
unpack-trees: simplify pattern_list freeing
commit e091228e17 ("sparse-checkout: update working directory
in-process", 2019-11-21) allowed passing a pre-defined set of patterns
to unpack_trees(). However, if o->pl was NULL, it would still read the
existing patterns and use those. If those patterns were read into a
data structure that was allocated, naturally they needed to be free'd.
However, despite the same function being responsible for knowing about
both the allocation and the free'ing, the logic for tracking whether to
free the pattern_list was hoisted to an outer function with an
additional flag in unpack_trees_options. Put the logic back in the
relevant function and discard the now unnecessary flag.
Reviewed-by: Derrick Stolee <dstolee@microsoft.com>
Signed-off-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'unpack-trees.h')
| -rw-r--r-- | unpack-trees.h | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/unpack-trees.h b/unpack-trees.h index 6d7c7b6..d351626 100644 --- a/unpack-trees.h +++ b/unpack-trees.h @@ -58,8 +58,7 @@ struct unpack_trees_options { quiet, exiting_early, show_all_errors, - dry_run, - keep_pattern_list; + dry_run; const char *prefix; int cache_bottom; struct dir_struct *dir; |