path: root/tree-walk.h
diff options
authorJeff King <>2019-07-31 04:38:15 (GMT)
committerJunio C Hamano <>2019-07-31 20:34:25 (GMT)
commit9055384710dd8963b125f4f87c24d8f67d9fa24f (patch)
tree927c9d4670548c932c3b13e1bfcee33ca431943c /tree-walk.h
parent947208b725188eb499625ebc5c6e43d54c97e4fc (diff)
tree-walk: drop oid from traverse_info
As the previous commit shows, the presence of an oid in each level of the traverse_info is confusing and ultimately not necessary. Let's drop it to make it clear that it will not always be set (as well as convince us that it's unused, and let the compiler catch any merges with other branches that do add new uses). Since the oid is part of name_entry, we'll actually stop embedding a name_entry entirely, and instead just separately hold the pathname, its length, and the mode. This makes the resulting code slightly more verbose as we have to pass those elements around individually. But it also makes it more clear what each code path is going to use (and in most of the paths, we really only care about the pathname itself). A few of these conversions are noisier than they need to be, as they also take the opportunity to rename "len" to "namelen" for clarity (especially where we also have "pathlen" or "ce_len" alongside). Signed-off-by: Jeff King <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'tree-walk.h')
1 files changed, 6 insertions, 2 deletions
diff --git a/tree-walk.h b/tree-walk.h
index 161e240..baa2aa6 100644
--- a/tree-walk.h
+++ b/tree-walk.h
@@ -56,7 +56,10 @@ enum get_oid_result get_tree_entry_follow_symlinks(struct object_id *tree_oid, c
struct traverse_info {
const char *traverse_path;
struct traverse_info *prev;
- struct name_entry name;
+ const char *name;
+ size_t namelen;
+ unsigned mode;
int pathlen;
struct pathspec *pathspec;
@@ -67,7 +70,8 @@ struct traverse_info {
int get_tree_entry(const struct object_id *, const char *, struct object_id *, unsigned short *);
-char *make_traverse_path(char *path, const struct traverse_info *info, const struct name_entry *n);
+char *make_traverse_path(char *path, const struct traverse_info *info,
+ const char *name, size_t namelen);
void setup_traverse_info(struct traverse_info *info, const char *base);
static inline int traverse_path_len(const struct traverse_info *info, const struct name_entry *n)