path: root/transport.c
diff options
authorJohannes Sixt <>2007-10-19 19:47:53 (GMT)
committerShawn O. Pearce <>2007-10-21 05:30:39 (GMT)
commit98158e9cfd2808613f305bf587ce697762c884bb (patch)
tree87502b9a44bf4ca790f60ce8639a903e23b4ac7a /transport.c
parentca5bb5d5390e4ec709ca3e11c451c58a836d4ee6 (diff)
Change git_connect() to return a struct child_process instead of a pid_t.
This prepares the API of git_connect() and finish_connect() to operate on a struct child_process. Currently, we just use that object as a placeholder for the pid that we used to return. A follow-up patch will change the implementation of git_connect() and finish_connect() to make full use of the object. Old code had early-return-on-error checks at the calling sites of git_connect(), but since git_connect() dies on errors anyway, these checks were removed. [sp: Corrected style nit of "conn == NULL" to "!conn"] Signed-off-by: Johannes Sixt <> Signed-off-by: Shawn O. Pearce <>
Diffstat (limited to 'transport.c')
1 files changed, 2 insertions, 7 deletions
diff --git a/transport.c b/transport.c
index 400af71..5132d28 100644
--- a/transport.c
+++ b/transport.c
@@ -601,18 +601,13 @@ static struct ref *get_refs_via_connect(const struct transport *transport)
struct git_transport_data *data = transport->data;
struct ref *refs;
int fd[2];
- pid_t pid;
char *dest = xstrdup(transport->url);
- pid = git_connect(fd, dest, data->uploadpack, 0);
- if (pid < 0)
- die("Failed to connect to \"%s\"", transport->url);
+ struct child_process *conn = git_connect(fd, dest, data->uploadpack, 0);
get_remote_heads(fd[0], &refs, 0, NULL, 0);
- finish_connect(pid);
+ finish_connect(conn);