path: root/transport.c
diff options
authorJonathan Tan <>2019-04-12 19:51:21 (GMT)
committerJunio C Hamano <>2019-04-18 01:53:51 (GMT)
commit35eb8240b0849b8d2cf675f1bed5d4dbf977372e (patch)
treead404051bab658934ca38baf699986d5bd4b93d6 /transport.c
parentaeb582a98374c094361cba1bd756dc6307432c42 (diff)
transport: die if server options are unsupported
Server options were added in commit 5e3548ef16 ("fetch: send server options when using protocol v2", 2018-04-24), supported only for protocol version 2. But if the user specifies server options, and the protocol version being used doesn't support them, the server options are silently ignored. Teach any transport users to die instead in this situation, just like how "push" dies if push options are provided when the server doesn't support them. Signed-off-by: Jonathan Tan <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'transport.c')
1 files changed, 10 insertions, 0 deletions
diff --git a/transport.c b/transport.c
index e078812..7744611 100644
--- a/transport.c
+++ b/transport.c
@@ -252,6 +252,14 @@ static int connect_setup(struct transport *transport, int for_push)
return 0;
+static void die_if_server_options(struct transport *transport)
+ if (!transport->server_options || !transport->server_options->nr)
+ return;
+ advise(_("see protocol.version in 'git help config' for more details"));
+ die(_("server options require protocol version 2 or later"));
* Obtains the protocol version from the transport and writes it to
* transport->data->version, first connecting if not already connected.
@@ -286,6 +294,7 @@ static struct ref *handshake(struct transport *transport, int for_push,
case protocol_v1:
case protocol_v0:
+ die_if_server_options(transport);
get_remote_heads(&reader, &refs,
for_push ? REF_NORMAL : 0,
@@ -363,6 +372,7 @@ static int fetch_refs_via_pack(struct transport *transport,
case protocol_v1:
case protocol_v0:
+ die_if_server_options(transport);
refs = fetch_pack(&args, data->fd, data->conn,
refs_tmp ? refs_tmp : transport->remote_refs,
dest, to_fetch, nr_heads, &data->shallow,