summaryrefslogtreecommitdiff
path: root/transport.c
diff options
context:
space:
mode:
authorJonathan Tan <jonathantanmy@google.com>2017-12-12 23:10:56 (GMT)
committerJunio C Hamano <gitster@pobox.com>2017-12-13 00:50:56 (GMT)
commit170078693fcccd614406e1c3c9fcbea8aaba0c13 (patch)
tree56e480fab5e55e4894d80a6208850a268c298ac6 /transport.c
parent3013dff8662eae06457fe6e5348dfe2270810ab2 (diff)
downloadgit-170078693fcccd614406e1c3c9fcbea8aaba0c13.zip
git-170078693fcccd614406e1c3c9fcbea8aaba0c13.tar.gz
git-170078693fcccd614406e1c3c9fcbea8aaba0c13.tar.bz2
transport: remove unused "push" in vtable
After commit 0d0bac67ce3b ("transport: drop support for git-over-rsync", 2016-02-01), no transport in Git populates the "push" entry in the transport vtable. Remove this entry. Signed-off-by: Jonathan Tan <jonathantanmy@google.com> Reviewed-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'transport.c')
-rw-r--r--transport.c9
1 files changed, 1 insertions, 8 deletions
diff --git a/transport.c b/transport.c
index f1e2f61..8c4fc54 100644
--- a/transport.c
+++ b/transport.c
@@ -627,7 +627,6 @@ void transport_take_over(struct transport *transport,
transport->set_option = NULL;
transport->get_refs_list = get_refs_via_connect;
transport->fetch = fetch_refs_via_pack;
- transport->push = NULL;
transport->push_refs = git_transport_push;
transport->disconnect = disconnect_git;
transport->smart_options = &(data->options);
@@ -969,13 +968,7 @@ int transport_push(struct transport *transport,
*reject_reasons = 0;
transport_verify_remote_names(refspec_nr, refspec);
- if (transport->push) {
- /* Maybe FIXME. But no important transport uses this case. */
- if (flags & TRANSPORT_PUSH_SET_UPSTREAM)
- die("This transport does not support using --set-upstream");
-
- return transport->push(transport, refspec_nr, refspec, flags);
- } else if (transport->push_refs) {
+ if (transport->push_refs) {
struct ref *remote_refs;
struct ref *local_refs = get_local_heads();
int match_flags = MATCH_REFS_NONE;