diff options
| author | Stefan Beller <sbeller@google.com> | 2015-07-31 23:57:57 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2015-08-03 20:03:58 (GMT) |
| commit | ae25fd39bc6fdc3457976c8d3398aa0fda352f97 (patch) | |
| tree | 30ba0698b4904629788c84aaa04315e33d221494 /transport-helper.c | |
| parent | be94b339b698cf3ac869ef9666b82b75032add3a (diff) | |
| download | git-ae25fd39bc6fdc3457976c8d3398aa0fda352f97.zip git-ae25fd39bc6fdc3457976c8d3398aa0fda352f97.tar.gz git-ae25fd39bc6fdc3457976c8d3398aa0fda352f97.tar.bz2 | |
transport-helper: die on errors reading refs.
We check the return value of read_ref in 19 out of 21 cases.
This adds checks to the missing cases.
Signed-off-by: Stefan Beller <sbeller@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'transport-helper.c')
| -rw-r--r-- | transport-helper.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/transport-helper.c b/transport-helper.c index 5d99a6b..68e498e 100644 --- a/transport-helper.c +++ b/transport-helper.c @@ -490,7 +490,8 @@ static int fetch_with_import(struct transport *transport, else private = xstrdup(name); if (private) { - read_ref(private, posn->old_sha1); + if (read_ref(private, posn->old_sha1) < 0) + die("Could not read ref %s", private); free(private); } } @@ -1019,7 +1020,10 @@ static struct ref *get_refs_list(struct transport *transport, int for_push) if (eon) { if (has_attribute(eon + 1, "unchanged")) { (*tail)->status |= REF_STATUS_UPTODATE; - read_ref((*tail)->name, (*tail)->old_sha1); + if (read_ref((*tail)->name, + (*tail)->old_sha1) < 0) + die(N_("Could not read ref %s"), + (*tail)->name); } } tail = &((*tail)->next); |