summaryrefslogtreecommitdiff
path: root/trailer.c
diff options
context:
space:
mode:
authorJunio C Hamano <gitster@pobox.com>2015-09-02 19:50:21 (GMT)
committerJunio C Hamano <gitster@pobox.com>2015-09-02 19:50:21 (GMT)
commitcdd00dfe9431b431e488d0bb77d39f1461a9dcc5 (patch)
treead2fad0185d31fe40e21deec894f23dc202edfea /trailer.c
parent8f8386eeb43e12a6c9704915994e6075a5a9b1cf (diff)
parent5c99995df8ee3b02224f0e2e86a3d1e4bb2f7348 (diff)
downloadgit-cdd00dfe9431b431e488d0bb77d39f1461a9dcc5.zip
git-cdd00dfe9431b431e488d0bb77d39f1461a9dcc5.tar.gz
git-cdd00dfe9431b431e488d0bb77d39f1461a9dcc5.tar.bz2
Merge branch 'cc/trailers-corner-case-fix'
The "interpret-trailers" helper mistook a multi-paragraph title of a commit log message with a colon in it as the end of the trailer block. * cc/trailers-corner-case-fix: trailer: support multiline title
Diffstat (limited to 'trailer.c')
-rw-r--r--trailer.c15
1 files changed, 11 insertions, 4 deletions
diff --git a/trailer.c b/trailer.c
index b808868..6f3416f 100644
--- a/trailer.c
+++ b/trailer.c
@@ -735,15 +735,22 @@ static int find_patch_start(struct strbuf **lines, int count)
*/
static int find_trailer_start(struct strbuf **lines, int count)
{
- int start, only_spaces = 1;
+ int start, end_of_title, only_spaces = 1;
+
+ /* The first paragraph is the title and cannot be trailers */
+ for (start = 0; start < count; start++) {
+ if (lines[start]->buf[0] == comment_line_char)
+ continue;
+ if (contains_only_spaces(lines[start]->buf))
+ break;
+ }
+ end_of_title = start;
/*
* Get the start of the trailers by looking starting from the end
* for a line with only spaces before lines with one separator.
- * The first line must not be analyzed as the others as it
- * should be either the message title or a blank line.
*/
- for (start = count - 1; start >= 1; start--) {
+ for (start = count - 1; start >= end_of_title; start--) {
if (lines[start]->buf[0] == comment_line_char)
continue;
if (contains_only_spaces(lines[start]->buf)) {