path: root/trace.c
diff options
authorJeff King <>2013-07-10 00:18:40 (GMT)
committerJunio C Hamano <>2013-07-10 05:23:04 (GMT)
commit4621085b7eb2f4cffe16d508988ff9b4a874b4ef (patch)
treee00d04f064c23918768aafaa93656a07949a95db /trace.c
parentedca4152560522a431a51fc0a06147fc680b5b18 (diff)
add missing "format" function attributes
For most of our functions that take printf-like formats, we use gcc's __attribute__((format)) to get compiler warnings when the functions are misused. Let's give a few more functions the same protection. In most cases, the annotations do not uncover any actual bugs; the only code change needed is that we passed a size_t to transfer_debug, which expected an int. Since we expect the passed-in value to be a relatively small buffer size (and cast a similar value to int directly below), we can just cast away the problem. Signed-off-by: Jeff King <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'trace.c')
1 files changed, 1 insertions, 0 deletions
diff --git a/trace.c b/trace.c
index 5ec0e3b..3d744d1 100644
--- a/trace.c
+++ b/trace.c
@@ -75,6 +75,7 @@ static void trace_vprintf(const char *key, const char *fmt, va_list ap)
+__attribute__((format (printf, 2, 3)))
static void trace_printf_key(const char *key, const char *fmt, ...)
va_list ap;