summaryrefslogtreecommitdiff
path: root/templates
diff options
context:
space:
mode:
authorDenton Liu <liu.denton@gmail.com>2020-09-23 09:38:43 (GMT)
committerJunio C Hamano <gitster@pobox.com>2020-09-23 16:31:45 (GMT)
commit6a117da6e523a82115733682f4d3f59755897d5a (patch)
treedbb93c108c236466465959aa5c313c6981148c80 /templates
parent47ae905ffb98cc4d4fd90083da6bc8dab55d9ecc (diff)
downloadgit-6a117da6e523a82115733682f4d3f59755897d5a.zip
git-6a117da6e523a82115733682f4d3f59755897d5a.tar.gz
git-6a117da6e523a82115733682f4d3f59755897d5a.tar.bz2
hooks--pre-push.sample: modernize script
The preferred form for a command substitution is $() over ``. Use this form for the command substitution in the sample hook. The preferred form for conditional tests is to use `test` over []. Replace [] with `test`. Finally, replace all instances of "sha" with "oid". Signed-off-by: Denton Liu <liu.denton@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'templates')
-rwxr-xr-xtemplates/hooks--pre-push.sample16
1 files changed, 8 insertions, 8 deletions
diff --git a/templates/hooks--pre-push.sample b/templates/hooks--pre-push.sample
index 6187dbf..d0f3019 100755
--- a/templates/hooks--pre-push.sample
+++ b/templates/hooks--pre-push.sample
@@ -14,7 +14,7 @@
# Information about the commits which are being pushed is supplied as lines to
# the standard input in the form:
#
-# <local ref> <local sha1> <remote ref> <remote sha1>
+# <local ref> <local oid> <remote ref> <remote oid>
#
# This sample shows how to prevent push of commits where the log message starts
# with "WIP" (work in progress).
@@ -24,25 +24,25 @@ url="$2"
z40=0000000000000000000000000000000000000000
-while read local_ref local_sha remote_ref remote_sha
+while read local_ref local_oid remote_ref remote_oid
do
- if [ "$local_sha" = $z40 ]
+ if test "$local_oid" = $z40
then
# Handle delete
:
else
- if [ "$remote_sha" = $z40 ]
+ if test "$remote_oid" = $z40
then
# New branch, examine all commits
- range="$local_sha"
+ range="$local_oid"
else
# Update to existing branch, examine new commits
- range="$remote_sha..$local_sha"
+ range="$remote_oid..$local_oid"
fi
# Check for WIP commit
- commit=`git rev-list -n 1 --grep '^WIP' "$range"`
- if [ -n "$commit" ]
+ commit=$(git rev-list -n 1 --grep '^WIP' "$range")
+ if test -n "$commit"
then
echo >&2 "Found WIP commit in $local_ref, not pushing"
exit 1